Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle no user data for mobile number input #676

Closed
dirkcuys opened this issue Jul 14, 2020 · 2 comments
Closed

Correctly handle no user data for mobile number input #676

dirkcuys opened this issue Jul 14, 2020 · 2 comments

Comments

@dirkcuys
Copy link
Member

@s-kennedy I see you updated the mobile input here eabbe7b. This caused a problem when not entering a mobile number, since "+1" would be sent to the server which would make validation fail.

For now I've worked around the issue by adding back the hidden input that stores a cleaned up phone number 102e564. Maybe you can think of a cleaner solution?

@s-kennedy s-kennedy self-assigned this Jul 22, 2020
@s-kennedy
Copy link
Contributor

Looking into this further, it looks like the hidden field is the way to go for now... unless we want to fork the component repo and change the way it sets the input value. Probably more work than it's worth. Another problem though is that autocomplete messes up the country code selection. There's already an issue created for this: mukeshsoni/react-telephone-input#201. How much of a problem is this?

@shinysticker
Copy link

A fix for the autocomplete issue would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants