Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Links" accessibility action only works in a thread #1037

Closed
nikclayton opened this issue Oct 22, 2024 · 1 comment · Fixed by #1040
Closed

"Links" accessibility action only works in a thread #1037

nikclayton opened this issue Oct 22, 2024 · 1 comment · Fixed by #1040

Comments

@nikclayton
Copy link
Contributor

Reports from TalkingDroid account that the "Links" accessibility action only works in a thread, and not when viewing a timeline (or notifications).
@nikclayton
Copy link
Contributor Author

Hashtags and mentions are also not working properly in notifications.

nikclayton added a commit that referenced this issue Oct 23, 2024
@nikclayton
fix: Show links, mentions, and hashtag accessibility actions for noti…
f133e36 
…fications

Previous code checked the item was a `StatusViewData`, which is not
true for notifications, and meant the links, mentions, and hashtags
accessibility features were not available.

Change this to `IStatusViewData`, which notifications do implement.

Fixes #1037
@nikclayton nikclayton mentioned this issue Oct 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pachli roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Show links, mentions, and hashtag accessibility actions for notifications pachli/pachli-android
1 participant
@nikclayton