-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking: Reported issues Jan 2025 #1234
Comments
Keith, I need some extra information about the "Timeline stops loading" issue you reported. Here's what's supposed to happen: On your device the database is treated as a local cache that can be discarded at any time. When that happens fresh data is fetched from your server and used to re-populate the cache. When you "refresh" your home timeline (either the "refresh" menu, or by pulling down on the list of posts):
When you "Load from newest" from the menu much the same thing happens, except instead of trying to load the posts around where you were reading, your server is asked for the newest posts. When they load you're scrolled to the top of the newest posts, ignoring whatever your previous reading position was. In both cases, when you scroll, and you get close to the end of the posts that have been loaded so far, your server is contacted to get newer (or older, if you're scrolling down) posts. If the server responds with new posts they're added to the list. But if the server responds with no new posts then Pachli will stop trying to fetch new data until you explicitly refresh (either from the menu, or by swiping down on the list). |
So I can't see any specific questions to answer above, but i can think of a scenario that explains two of the issues I've seen. I haven't looked at the code so this is speculation based on behaviour, and what you describe above. Assume I have just opened the app, and clicked "load newest posts" to jump to the top. Everything is cleared except the latest posts. I scroll downwards, going back in time. Two symptoms can occur (these definitely do not happen in the mainline Pachli, only Current):
Both of these could be explained by the same thing: if Pachli has somehow lost track of where I am and thinks I'm higher up - e.g. 20-30 posts higher up in the list.
Speculating even more wildly - could this be because more posts have since come in at the top of the stream, but not been accounted for in the position that I'm in? e.g. let's say I scrolled down 100 posts, but in the meantime another 30 posts came in. Pachli thinks I'm on post 100, but it's forgotten to add the 30 new ones, so actually it should think I'm at post 130..? Dunno - that feels like a stretch. I don't have time to dive into the code to help track this down further I'm afraid. |
Version 2.9.1+353f123b hasn't crashed yet but is still only loading the last hour or so of my timeline, after which it's just posts that reference my username directly. |
@keefmarshall and if you check your timeline on the website and scroll down past that point, posts show up that don't appear in Pachli? If so, please can you:
That should let me see the network requests and response codes (not the actual content) so I can figure out what's happening. |
Yes, not only if I check on the website, but also in the mainline version of Pachli, there are many more posts in my timeline. This behaviour is specific to Current. I'll try to send a report as asked. |
The Pachli Current releases in Jan 2025 are crashing for some but not all users. This is to track the reported issues, collect feedback.
Current state
ReleasingReleased 2.9.1+ab958916. This contains fixes to PruneCacheWorker queries that may prevent the database from locking. Feedback / bug reports on earlier versions is not necessary.Versions / bug reports
Versions, newest first:
SetActiveAccountError.Unexpected
" (displays error instead of crashing)Reported issues
App crashing at startup
Fixed with 4233, 2.9.1+ab958916
Seen in:
Crash reports from:
Updating the user's notification marker (the ID of the most recent fetched notification) crashes, and looks like this:
I know it's the marker update that crashes because there should be a log message immediately after the marker is updated and it's not present, so the crash is there.
Suspect this is a symptom, not the cause -- some other query is crashing and left an open transaction, then all future transactions crash.
Working theory: The queries executed by PruneCacheWorker could trigger FK constraints and fail
NPE handling
SetActiveAccountError.Unexpected
**Note**: This is now handled by https://github.com//pull/1235. The app is probably still in an unusable state if this happens, but it should show the error.
Code is:
wantedAccount
is null here even though it shouldn't be. Fix is to add an error case for SQLiteException and display an error instead of crashing.TImeline stops loading posts
Seen in:
Timeline jumps when boosting
Seen in:
Other notes
The text was updated successfully, but these errors were encountered: