Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Viewer toolbar doesn't automatically hide #505

Closed
tinsukE opened this issue Mar 6, 2024 · 1 comment · Fixed by #507
Closed

Image Viewer toolbar doesn't automatically hide #505

tinsukE opened this issue Mar 6, 2024 · 1 comment · Fixed by #507

Comments

@tinsukE
Copy link
Contributor

tinsukE commented Mar 6, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
When viewing an Image, it is not straightforward to understand that tapping on it will hide the toolbar and alt sheet, and those elements might get in the way of them viewing the full image.

Describe the solution you'd like
Automatically hiding the toolbar and alt sheet after some short time might help the user two ways:

  1. Get out of their way when they're viewing an image with an aspect ratio so that those elements are on top of it.
  2. Showing them that those elements are hide-able, which might nudge into tapping to restore them and, consequently, learn about the "tap to hide/show" feature.

Additionally, this behavior could be cancelled when the user is actually interacting with the toolbar or the alt sheet.

Describe alternatives you've considered
Haven't thought of any, to be honest.

Additional context
A user reported that the toolbar overlaps the image content as a bug on: https://mastodon.online/@Sibshops/111966215305480340
@tinsukE
Copy link
Contributor Author

tinsukE commented Mar 6, 2024

I'm working on a suggested fix for this issue.

@tinsukE tinsukE mentioned this issue Mar 6, 2024
Merged
nikclayton pushed a commit that referenced this issue Mar 10, 2024
@tinsukE
feat: Auto-hide Image Viewer toolbar (#507)
bdf2d93 
Previous code showed the toolbar and caption when displaying the image,
and the user has to tap the screen to dismiss it.

New code is consistent with the video viewer; the toolbar and caption
is displayed for two seconds, and then auto-hides.

- Tapping after the hide displays the toolbar and caption, which will
  not auto-hide and requires a second tap to dismiss.

- Tapping the caption before it's hidden cancels the auto-hide

Fixes #505
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Mar 10, 2024
@tinsukE tinsukE mentioned this issue Mar 11, 2024
Merged
nikclayton added a commit that referenced this issue Mar 13, 2024
@tinsukE @nikclayton
feat: Improve Image Viewer toolbar auto-hide (#521)
5be93ac 
Cancel the auto-hide behavior in case the toolbar menu items are
interacted with.

Improves #505,
#507

---------

Co-authored-by: Nik Clayton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pachli roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Auto-hide Image Viewer toolbar tinsukE/pachli-android
1 participant
@tinsukE