From 97519391ff206d3cf63a71cb71db17dab5f2e862 Mon Sep 17 00:00:00 2001 From: Lavanya Singh Date: Thu, 2 Feb 2023 16:31:20 -0500 Subject: [PATCH] remove comment --- .../palantir/conjure/java/types/SafetyEvaluatorTest.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java b/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java index b5f0c1d14..5900dde0f 100644 --- a/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java +++ b/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java @@ -137,13 +137,12 @@ void testMapSafeKey() { .types(object) .types(SAFE_ALIAS) .build(); - // there's an ABI break between 4.28.0 -> 4.36.0 ConjureDefinitionValidator.validateAll(conjureDef, SafetyDeclarationRequirements.ALLOWED); SafetyEvaluator evaluator = new SafetyEvaluator(conjureDef); assertThat(evaluator.evaluate(object)).isEmpty(); } - private static Stream providesExternalRefTypes_ImportTime() { + private static Stream providesExternalRefTypes_WithSafety() { Type external = Type.external(ExternalReference.builder() .externalReference(TypeName.of("Long", "java.lang")) .fallback(Type.primitive(PrimitiveType.STRING)) @@ -153,8 +152,8 @@ private static Stream providesExternalRefTypes_ImportTime() { } @ParameterizedTest - @MethodSource("providesExternalRefTypes_ImportTime") - void testExternalRefType_AtImportTime(TypeDefinition typeDefinition, ConjureDefinition conjureDef) { + @MethodSource("providesExternalRefTypes_WithSafety") + void testExternalRefType_WithSafety(TypeDefinition typeDefinition, ConjureDefinition conjureDef) { ConjureDefinitionValidator.validateAll(conjureDef, SafetyDeclarationRequirements.ALLOWED); SafetyEvaluator evaluator = new SafetyEvaluator(conjureDef); assertThat(evaluator.evaluate(typeDefinition)).hasValue(LogSafety.DO_NOT_LOG);