dockerClean : does not remove dockerfileZip artifacts

[phreed]

What happened?

I ran:

./gradlew dockerClean

The relevant code:

gradle-docker/src/main/groovy/com/palantir/gradle/docker/PalantirDockerPlugin.groovy

Lines 58 to 61 in 34cf512

	Delete clean = project.tasks.create('dockerClean', Delete, {
	group = 'Docker'
	description = 'Cleans Docker build directory.'
	})

What did you want to happen?

I wanted it to remove the *.zip artifact from the distribution directory.

[phreed]

This is related to issue #471 as I would expect the distribution directory to be removed.

tasks {
    named<Zip>("dockerfileZip") {
        archiveFileName.set("${rootProject.name}.zip")
        destinationDirectory.set(layout.buildDirectory.dir("dist"))
    }
}

The destinationDirectory that is removed by dockerClean is 'docker' and its subdirectories.
One way to deal with this is to augment dockerClean as follows:

tasks {
    named<Delete>("dockerClean") {
        delete(layout.buildDirectory.dir("dist"))
    }
}

A better approach is probably to point the destinationDirectory to 'docker/dest'.
This approach is indicated in #471 .