Defect in Error Message Concerning Missing File

[phreed]

Critical Source Code

gradle-docker/src/main/groovy/com/palantir/gradle/docker/GenerateDockerCompose.groovy

Lines 44 to 47 in 34cf512

	void run() {
	if (!template.file) {
	throw new IllegalStateException("Could not find specified template file ${template.file}")
	}

Symptom

When the template file is not present the error does not include the name of the missing file.

 Execution failed for task ':docker-compose:janusgraph-client:generateDockerCompose'.
> Could not find specified template file false

The name of the file is not 'false'.

Cause

Use of template.file effectively calls getTemplate().isFile() which returns a boolean.
This is appropriate for the conditional test but the thrown exception message should be using template.path i.e. getTemplate().getPath().

[phreed]

As a side note, a nearly identical message appears here:

gradle-docker/src/main/groovy/com/palantir/gradle/docker/DockerExtension.groovy

Lines 70 to 74 in 34cf512

	public void setDockerComposeTemplate(String dockerComposeTemplate) {
	this.dockerComposeTemplate = dockerComposeTemplate
	Preconditions.checkArgument(project.file(dockerComposeTemplate).exists(),
	"Could not find specified template file: %s", project.file(dockerComposeTemplate))
	}