Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to list all tags #817

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

RAtioNAn
Copy link

@RAtioNAn RAtioNAn commented Jul 10, 2024

Before this PR

For now if there are multiple tags on commit only one of them will be returned when getLastTag() method is invoked. There is no way to query, filter or search for specific tag
in case there is more than one.

After this PR

This PR adds new property to get all tags on the commit thus allowing the user to choose one of them for his specific scenario.

==COMMIT_MSG==
Adding functionality to list all tags on commit
==COMMIT_MSG==

Possible downsides?

New method added to interface. No code change is required for current users if they do not need this functionality.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-git-version, @RAtioNAn! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Jul 10, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Ability to list all tags

Check the box to generate changelog(s)

  • Generate changelog entry

@RAtioNAn
Copy link
Author

RAtioNAn commented Nov 8, 2024

Hello,
Can someone please provide any kind of feedback on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants