Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer.startSpan should support overloads to parameterize messages #177

Open
carterkozak opened this issue Jun 14, 2019 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@carterkozak
Copy link
Contributor

What happened?

We do a great deal of unnecessary string concatenation in span names which can be completely avoided for unsampled traces:

String operation = "Jersey: " + requestContext.getMethod() + " " + path;

What did you want to happen?

Slf4j style overloads to construct trace strings only for sampled operations

@carterkozak
Copy link
Contributor Author

Instead of parameterized methods we could take Supplier<String>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants