Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span completion should not return the completed span #35

Open
carterkozak opened this issue Nov 1, 2018 · 1 comment
Open

span completion should not return the completed span #35

carterkozak opened this issue Nov 1, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
Major API Revision

Comments

@carterkozak
Copy link
Contributor

By returning the completed span we require execution to be traced regardless of whether it will be observed. We can avoid this additional work when tracing is not requested. The solution to #34 should cover this case.

Potential non-break (API bend?): completeSpan returns an optional of the completed span, we may be able to return an empty optional when the trace is not observed.
@carterkozak carterkozak added the enhancement New feature or request label Nov 1, 2018
@carterkozak carterkozak added this to the Major API Revision milestone Nov 1, 2018
@j-baker
Copy link
Contributor

j-baker commented Nov 16, 2018

Isn't this the reason why we have fastCompleteSpan too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Major API Revision
Development

No branches or pull requests
2 participants
@j-baker @carterkozak