From 7cad3cf2f994e6a332884ed64e9dc039f83bbed8 Mon Sep 17 00:00:00 2001
From: Josh Goldberg <joshuakgoldberg@outlook.com>
Date: Tue, 27 Sep 2016 11:09:52 -0700
Subject: [PATCH] Remove no-duplicate-key rule (#1109)

Fixes #885.
---
 docs/_data/rules.json                        |  11 --
 docs/_site/rules/index.html                  |   3 -
 docs/_site/rules/no-duplicate-key/index.html | 137 -------------------
 docs/rules/no-duplicate-key/index.html       |  16 ---
 src/configs/recommended.ts                   |   1 -
 src/rules/noDuplicateKeyRule.ts              |  69 ----------
 test/rules/no-duplicate-key/test.ts.lint     |  46 -------
 test/rules/no-duplicate-key/tslint.json      |   5 -
 8 files changed, 288 deletions(-)
 delete mode 100644 docs/_site/rules/no-duplicate-key/index.html
 delete mode 100644 docs/rules/no-duplicate-key/index.html
 delete mode 100644 src/rules/noDuplicateKeyRule.ts
 delete mode 100644 test/rules/no-duplicate-key/test.ts.lint
 delete mode 100644 test/rules/no-duplicate-key/tslint.json
diff --git a/docs/_data/rules.json b/docs/_data/rules.json
index 8b8f3584702..57a83746dba 100644
--- a/docs/_data/rules.json
+++ b/docs/_data/rules.json
@@ -457,17 +457,6 @@
     ],
     "type": "maintainability"
   },
-  {
-    "ruleName": "no-duplicate-key",
-    "description": "Disallows duplicate keys in object literals.",
-    "rationale": "\nThere is no good reason to define an object literal with the same key twice.\nThis rule is now implemented in the TypeScript compiler and does not need to be used.",
-    "optionsDescription": "Not configurable.",
-    "options": null,
-    "optionExamples": [
-      "true"
-    ],
-    "type": "functionality"
-  },
   {
     "ruleName": "no-duplicate-variable",
     "description": "Disallows duplicate variable declarations in the same block scope.",
diff --git a/docs/_site/rules/index.html b/docs/_site/rules/index.html
index a4106379c02..10228097967 100644
--- a/docs/_site/rules/index.html
+++ b/docs/_site/rules/index.html
@@ -118,9 +118,6 @@ <h3>Functionality</h3>
   <li><a href="no-debugger">no-debugger</a> - Disallows <code>debugger</code> statements.
 </li>
  
-  <li><a href="no-duplicate-key">no-duplicate-key</a> - Disallows duplicate keys in object literals.
-</li>
- 
   <li><a href="no-duplicate-variable">no-duplicate-variable</a> - Disallows duplicate variable declarations in the same block scope.
 </li>
  
diff --git a/docs/_site/rules/no-duplicate-key/index.html b/docs/_site/rules/no-duplicate-key/index.html
deleted file mode 100644
index 78d164884fd..00000000000
--- a/docs/_site/rules/no-duplicate-key/index.html
+++ /dev/null
@@ -1,137 +0,0 @@
-<!DOCTYPE html>
-<html>
-
-  <head>
-    <meta charset="utf-8">
-    <meta name="viewport" content="width=device-width initial-scale=1" />
-    <meta http-equiv="X-UA-Compatible" content="IE=edge">
-
-    <title>Rule: no-duplicate-key</title>
-    <meta name="description" content="TSLint documentation. A linter for the TypeScript language.
-">
-
-    <link rel="stylesheet" href="/tslint/css/main.css">
-    <link rel="canonical" href="https://palantir.github.io//tslint/rules/no-duplicate-key/">
-</head>
-
-
-  <body>
-
-    
-
-<header class="header">
-  <section class="site-header">
-      <a class="site-title" href="/tslint/">TSLint</a>
-      <nav class="site-nav">
-        <a class="page-link" href="/tslint/usage/cli">Usage</a>
-        <a class="page-link" href="/tslint/rules">Rules</a>
-        <a class="page-link" href="/tslint/develop/custom-rules">Develop</a>
-        <a class="page-link" href="/tslint/news">News</a>
-      </nav>
-  </section>
-  
-</header>
-
-
-    <div class="main-content">
-        <div class="page">
-   <article class="page-content">
-      
-      <header class="post-header">
-         <h1 class="post-title">Rule: no-duplicate-key</h1>
-         <p></p>
-      </header>
-      
-
-      <p>Disallows duplicate keys in object literals.</p>
-
-
-
-   <h5>Rationale</h5>
-   
-<p>There is no good reason to define an object literal with the same key twice.
-This rule is now implemented in the TypeScript compiler and does not need to be used.</p>
-
-
-
-
-<h3>Config</h3>
-<p>Not configurable.</p>
-
-
-<h5>Examples</h5>
-
-<pre>
-"no-duplicate-key": true
-</pre>
-
-
-<h5>Schema</h5>
-<pre>
-null
-</pre>
-   </article>
-   <section class="page-sidebar">
-      
-
-      
-      
-
-      
-      
-
-      
-   </section>
-
-</div>
-
-        <footer class="site-footer">
-  <div class="footer-col-wrapper">
-    <div class="footer-col  footer-col-1">
-      <ul class="contact-list">
-        <li>©2016 Palantir Technologies under <a href="https://github.com/palantir/tslint/blob/master/LICENSE">Apache 2.0</a></li>
-        <li>Styles based off of the <a href="https://github.com/jasonlong/cayman-theme">Cayman Theme</a> by Jason Long.
-        <li>Issues? <a href="https://github.com/palantir/tslint">Let us know on GitHub.</a></li>
-      </ul>
-    </div>
-
-    <div class="footer-col  footer-col-2">
-      <ul class="social-media-list">
-        
-        <li>
-          <a href="https://github.com/palantir/tslint">
-            <span class="icon  icon--github">
-              <svg viewBox="0 0 16 16">
-                <path fill="#828282" d="M7.999,0.431c-4.285,0-7.76,3.474-7.76,7.761 c0,3.428,2.223,6.337,5.307,7.363c0.388,0.071,0.53-0.168,0.53-0.374c0-0.184-0.007-0.672-0.01-1.32 c-2.159,0.469-2.614-1.04-2.614-1.04c-0.353-0.896-0.862-1.135-0.862-1.135c-0.705-0.481,0.053-0.472,0.053-0.472 c0.779,0.055,1.189,0.8,1.189,0.8c0.692,1.186,1.816,0.843,2.258,0.645c0.071-0.502,0.271-0.843,0.493-1.037 C4.86,11.425,3.049,10.76,3.049,7.786c0-0.847,0.302-1.54,0.799-2.082C3.768,5.507,3.501,4.718,3.924,3.65 c0,0,0.652-0.209,2.134,0.796C6.677,4.273,7.34,4.187,8,4.184c0.659,0.003,1.323,0.089,1.943,0.261 c1.482-1.004,2.132-0.796,2.132-0.796c0.423,1.068,0.157,1.857,0.077,2.054c0.497,0.542,0.798,1.235,0.798,2.082 c0,2.981-1.814,3.637-3.543,3.829c0.279,0.24,0.527,0.713,0.527,1.437c0,1.037-0.01,1.874-0.01,2.129 c0,0.208,0.14,0.449,0.534,0.373c3.081-1.028,5.302-3.935,5.302-7.362C15.76,3.906,12.285,0.431,7.999,0.431z"/>
-              </svg>
-            </span>
-
-            <span class="username">palantir/tslint</span>
-          </a>
-        </li>
-        
-
-        
-        <li>
-          <a href="https://twitter.com/PalantirTech">
-            <span class="icon  icon--twitter">
-              <svg viewBox="0 0 16 16">
-                <path fill="#828282" d="M15.969,3.058c-0.586,0.26-1.217,0.436-1.878,0.515c0.675-0.405,1.194-1.045,1.438-1.809
-                c-0.632,0.375-1.332,0.647-2.076,0.793c-0.596-0.636-1.446-1.033-2.387-1.033c-1.806,0-3.27,1.464-3.27,3.27 c0,0.256,0.029,0.506,0.085,0.745C5.163,5.404,2.753,4.102,1.14,2.124C0.859,2.607,0.698,3.168,0.698,3.767 c0,1.134,0.577,2.135,1.455,2.722C1.616,6.472,1.112,6.325,0.671,6.08c0,0.014,0,0.027,0,0.041c0,1.584,1.127,2.906,2.623,3.206 C3.02,9.402,2.731,9.442,2.433,9.442c-0.211,0-0.416-0.021-0.615-0.059c0.416,1.299,1.624,2.245,3.055,2.271 c-1.119,0.877-2.529,1.4-4.061,1.4c-0.264,0-0.524-0.015-0.78-0.046c1.447,0.928,3.166,1.469,5.013,1.469 c6.015,0,9.304-4.983,9.304-9.304c0-0.142-0.003-0.283-0.009-0.423C14.976,4.29,15.531,3.714,15.969,3.058z"/>
-              </svg>
-            </span>
-
-            <span class="username">PalantirTech</span>
-          </a>
-        </li>
-        
-      </ul>
-    </div>
-  </div>
-</footer>
-
-    </div>
-
-  </body>
-
-</html>
diff --git a/docs/rules/no-duplicate-key/index.html b/docs/rules/no-duplicate-key/index.html
deleted file mode 100644
index cae244b5058..00000000000
--- a/docs/rules/no-duplicate-key/index.html
+++ /dev/null
@@ -1,16 +0,0 @@
----
-ruleName: no-duplicate-key
-description: Disallows duplicate keys in object literals.
-rationale: |-
-
-  There is no good reason to define an object literal with the same key twice.
-  This rule is now implemented in the TypeScript compiler and does not need to be used.
-optionsDescription: Not configurable.
-options: null
-optionExamples:
-  - 'true'
-type: functionality
-optionsJSON: 'null'
-layout: rule
-title: 'Rule: no-duplicate-key'
----
\ No newline at end of file
diff --git a/src/configs/recommended.ts b/src/configs/recommended.ts
index d881ddc899f..323c6fd0be8 100644
--- a/src/configs/recommended.ts
+++ b/src/configs/recommended.ts
@@ -54,7 +54,6 @@ export const rules = {
     "no-construct": true,
     "no-constructor-vars": false,
     "no-debugger": true,
-    "no-duplicate-key": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
diff --git a/src/rules/noDuplicateKeyRule.ts b/src/rules/noDuplicateKeyRule.ts
deleted file mode 100644
index 9f8973f72ab..00000000000
--- a/src/rules/noDuplicateKeyRule.ts
+++ /dev/null
@@ -1,69 +0,0 @@
-/**
- * @license
- * Copyright 2013 Palantir Technologies, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import * as ts from "typescript";
-
-import * as Lint from "../lint";
-
-export class Rule extends Lint.Rules.AbstractRule {
-    /* tslint:disable:object-literal-sort-keys */
-    public static metadata: Lint.IRuleMetadata = {
-        ruleName: "no-duplicate-key",
-        description: "Disallows duplicate keys in object literals.",
-        rationale: Lint.Utils.dedent`
-            There is no good reason to define an object literal with the same key twice.
-            This rule is now implemented in the TypeScript compiler and does not need to be used.`,
-        optionsDescription: "Not configurable.",
-        options: null,
-        optionExamples: ["true"],
-        type: "functionality",
-    };
-    /* tslint:enable:object-literal-sort-keys */
-
-    public static FAILURE_STRING_FACTORY = (name: string) => `Duplicate key '${name}'`;
-
-    public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
-        return this.applyWithWalker(new NoDuplicateKeyWalker(sourceFile, this.getOptions()));
-    }
-}
-
-class NoDuplicateKeyWalker extends Lint.RuleWalker {
-    private objectKeysStack: {[key: string]: boolean}[] = [];
-
-    public visitObjectLiteralExpression(node: ts.ObjectLiteralExpression) {
-        this.objectKeysStack.push(Object.create(null));
-        super.visitObjectLiteralExpression(node);
-        this.objectKeysStack.pop();
-    }
-
-    public visitPropertyAssignment(node: ts.PropertyAssignment) {
-        const objectKeys = this.objectKeysStack[this.objectKeysStack.length - 1];
-        const keyNode = node.name;
-
-        if (keyNode.kind === ts.SyntaxKind.Identifier) {
-            const key = (<ts.Identifier> keyNode).text;
-            if (objectKeys[key]) {
-                const failureString = Rule.FAILURE_STRING_FACTORY(key);
-                this.addFailure(this.createFailure(keyNode.getStart(), keyNode.getWidth(), failureString));
-            } else {
-                objectKeys[key] = true;
-            }
-        }
-
-        super.visitPropertyAssignment(node);
-    }
-}
diff --git a/test/rules/no-duplicate-key/test.ts.lint b/test/rules/no-duplicate-key/test.ts.lint
deleted file mode 100644
index 78ce9d297b2..00000000000
--- a/test/rules/no-duplicate-key/test.ts.lint
+++ /dev/null
@@ -1,46 +0,0 @@
-var a = {
-    a: 1,
-    b: 2
-};
-
-var x = {
-    axa: 1,
-    bd: 2,
-    c: 3,
-    axa: 4,
-    ~~~                [Duplicate key 'axa']
-    d: 5,
-    ba: 3,
-    bd: 6,
-    ~~                [Duplicate key 'bd']
-    axa: 6
-    ~~~               [Duplicate key 'axa']
-};
-
-var z = {
-    c: [1, 2, 3],
-    d: {
-        b: "b",
-        a: 11,
-        c: [11, 22, 33]
-    },
-    a: 1,
-    b: "a"
-};
-
-var interspersed = {
-    duplicated: 1,
-    newContext: {},
-    duplicated: 2
-    ~~~~~~~~~~               [Duplicate key 'duplicated']
-};
-
-var n = {
-    constructor: function () {},
-    hasOwnProperty: function () {}
-};
-
-var foo = {
-    ["ab" + "cd"]: "efgh",
-    [x.axa]: "bar"
-}
diff --git a/test/rules/no-duplicate-key/tslint.json b/test/rules/no-duplicate-key/tslint.json
deleted file mode 100644
index 69550402f75..00000000000
--- a/test/rules/no-duplicate-key/tslint.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-  "rules": {
-    "no-duplicate-key": true
-  }
-}
