viem feedback

[jxom]

Hey! viem author here!

Saw ya'll starting to use viem. Let me know if you have any feedback. 🙇‍♂️

[0xjojoex]

Hi @jxom Thanks for the awesome package!
We notice the benefits of bundle size and runtime performance (decodeFunctionResult) when trying to put the router package on the edge.

some questions when converting to viem

1. seems like blockNumber has to be never but not undefined

   pancake-frontend/packages/smart-router/evm/v3-router/providers/multicallSwapProvider.ts

   Lines 90 to 95 in 1e8fc68

   	// @ts-ignore
   	blockNumber: blockNumberOverride
   	? isPromise(blockNumberOverride)
   	? BigInt(JSBI.toNumber(JSBI.BigInt(await blockNumberOverride)))
   	: BigInt(JSBI.toNumber(JSBI.BigInt(blockNumberOverride)))
   	: (undefined as never),

2. Will return value support object later on?

Again, really appreciate your team works

[jxom]

1. Should always be bigint | undefined – can pull the repo and take a quick look why it'd be casting to never.

2. For ABI decoding, we only represent "structish" tuples as objects, but not solidity return tuples (for consistency – to generally avoid confusion between a "struct"-like tuple and a return tuple). Seems that the multicall function on your contracts returns a tuple of two elements, so it'd return an array. If the multicall function returned a struct, then it would return an object.

[jxom]

Update for 1: You will need to set target: "es2020" or above in tsconfig.json (for bigints) – then it should work!

[0xjojoex]

Still feel sad about 2. that I used to use typescript autocomplete to check the response value.

[jxom]

Shouldn't be an issue once microsoft/TypeScript#44939 is resolved.