Skip to content

DEP: update python-calamine to 0.3.2 #61606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chilin0525
Copy link
Contributor

@chilin0525 chilin0525 commented Jun 8, 2025

This PR updates the calamine engine dependency to version 0.3.2, which includes the upstream fix for leading-zero truncation in VLOOKUP-derived Excel cells.

@chilin0525 chilin0525 requested a review from mroeschke as a code owner June 8, 2025 07:05
@chilin0525 chilin0525 marked this pull request as draft June 8, 2025 07:05
@datapythonista
Copy link
Member

It'd be good to either link an existing issue, or to write a description, so we can understand why we should merge this.

@chilin0525
Copy link
Contributor Author

chilin0525 commented Jun 10, 2025

@datapythonista Thanks for the reminder! I’ve now added the issue link for clarity. Since this is my first PR involving a package version bump, I wanted to ask:

  1. Does the pandas community support this upgrade to calamine >= 0.3.2? If it’s not aligned with project goals, I’m happy to close the PR.
  2. If the upgrade is approved, would you like me to add a unit test covering the original issue scenario?

Thanks!

@datapythonista
Copy link
Member

Thanks for the context. This looks reasonable. In general we support dependencies that are two years old. Given there is a bug, I guess it can make sense to require a version that is newer than that. @mroeschke @rhshadrach do you have an opinion on whether it's more important to be compatible with older versions one of the libraries to read Excel, or to prevent a bug it has?

@rhshadrach
Copy link
Member

Given there is a bug, I guess it can make sense to require a version that is newer than [2 years].
...
do you have an opinion on whether it's more important to be compatible with older versions one of the libraries to read Excel, or to prevent a bug it has?

Every optional dependency has bugfixes on just about every release, I think a bugfix would only justify bumping the minimum version if it is of an serious nature. Security issues as well. I do not think this is the case here.

@datapythonista datapythonista added the Dependencies Required and optional dependencies label Jun 19, 2025
@datapythonista
Copy link
Member

Let's close this then. I assume many users create a fresh environment and they'll get a new version anyway. For the people who has environments with the old dependency, hopefully they can find information that leads them to upgrading the buggy version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants