Restrict only in posting commits for elapsed time decisions #150
+3
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankona
reviewed
Jun 14, 2023
| ) | ||
|
|
||
| func main() { | ||
| r, err := git.PlainOpen(".") | ||
| lastCommitDateLine, err := exec.Command("git", "log", "-1", "--diff-filter=A", "--pretty=%aI", "--", "content/posts").Output() |
There was a problem hiding this comment.
git は巨大だから全部は対応できてないんす。
と書いてあったけど、この箇所とかまさにでした
There was a problem hiding this comment.
FYI
treefmtという自分も一部で使っているプロジェクトがあって、それも最近 go-git への依存性を落としてました
https://github.com/numtide/treefmt/releases/tag/v2.1.0
In addition, we no longer rely on [go-git](https://github.com/go-git/go-git); instead, we use git itself.
We have seen some issues with [go-git](https://github.com/go-git/go-git) and decided that it wasn't adding much value and would always remain a source of discrepancy with git itself.
pankona
approved these changes
Jun 14, 2023
|
やっていこう |
|
ありがとうございます、先生の新作楽しみです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
現在のリマインダー判定ロジックだと、既存のデータに対する typo 修正やラベルの付け外し等で生じる変化に対しても「記事を書いた」という扱いになってリマインダーが送られません。
これはパン粉さんの投稿を楽しみにしている読者に対して不誠実、或いは「最後にブログを書いてから n 日過ぎました」という目的に対して不正確かと思いますので、ファイルの増分が確認されない限り投稿していないという判定に変えてみました。
go-git は --diff-filter 周りへ対応できていないようなので、git コマンドへ直接依存するようにしています。
refs: