Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl timeout to New Relic API request, to prevent hung php worker / failed deploy workflow #155

Open
tinefin opened this issue Nov 28, 2018 · 0 comments

Comments

@tinefin
Copy link

tinefin commented Nov 28, 2018

It would be great to add a timeout to the curl request somewhere around here:
https://github.com/pantheon-systems/quicksilver-examples/blob/master/new_relic_deploy/new_relic_deploy.php#L63L69

As php does not count external processing toward php timeout, it will cause the php worker to hang in case New Relic fails to respond. This will also cause the Deploy workflow to be marked as failed on the site's Dashboard.
http://php.net/manual/en/info.configuration.php#ini.max-execution-time
http://php.net/manual/en/function.set-time-limit.php#refsect1-function.set-time-limit-notes

Internal support ticket reference:
120299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant