P.S. Any advice on the failing "Ensure PR has release notes (pull_request)" check?

Error: Please do one of:

- add release notes to the appropriate file in `docs/notes`

- label this PR with `release-notes:not-required` if it does not need them (for
  instance, if this is fixing a minor typo in documentation)

- label this PR with `category:internal` if it's an internal change

Looks good. I've marked this bugfix for backporting

To satisfy the "Ensure PR has release notes" check, you'd need to add a changelog to "docs/notes/2.25.x.md". Probably under the "General" heading.

Bump ^^
This is ready for a final review

Sorry for the delay! Looks good. I wanted to confirm that this wouldn't alter anything for zipfiles with extensions. It would be a shame if we broke reproduceable builds or worse.

I can confirm that zipfiles produced with --adjust-sfx are byte-for-byte equivalent with those produced without it in the case that there is no self-extracting information. zip reports. If you're trying this experiment yourself, beware that creating a zipfile will alter the atime, but not always (probably caching or something).

head -c 10M </dev/urandom >myfile
touch -at 11111111 myfile
zip 0.zip myfile
touch -at 11111111 myfile
zip --adjust-sfx 1 myfile

xxd 0.zip > 0.hex
xxd 1 > 1.hex
diff 0.hex 1.hex

I also checked that most major distros packaged a zip that has this option. Debian, Arch, and Alpine all bundle Info-Zip's implementation, which supports this option. Busybox does not implement zip so we don't have to worry about that.

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.22.x

Successfully opened #21707.

✔️ 2.23.x

Successfully opened #21706.

✔️ 2.24.x

Successfully opened #21705.

Thanks again for your contributions!

🤖 Beep Boop here's my run link