Add marshalling to Private (TPM2B_PRIVATE) #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandsimon
force-pushed
the
sbr/add_public_marshalling
branch
from
c961edf to
0d5e37c
Compare
|
Thanks for the PR. It would also be great if you could add some tests for this as well. |
brandsimon
force-pushed
the
sbr/add_public_marshalling
branch
from
e3a0a7f to
d9ba0d9
Compare
|
@Superhepper good catch, done |
|
Sorry for not noticing this the first time but it is better to implement the |
ionut-arm
reviewed
Oct 16, 2023
tss-esapi/tests/integration_tests/structures_tests/buffers_tests/private.rs
Outdated
Show resolved
Hide resolved
brandsimon
force-pushed
the
sbr/add_public_marshalling
branch
from
46a3d9d to
7190f3d
Compare
|
@Superhepper no worries, code looks cleaner with the |
Superhepper
reviewed
Oct 18, 2023
tss-esapi/tests/integration_tests/structures_tests/buffers_tests/private.rs
Show resolved
Hide resolved
Signed-off-by: Simon Brand <[email protected]>
brandsimon
force-pushed
the
sbr/add_public_marshalling
branch
from
ad16e07 to
8066e05
Compare
Superhepper
approved these changes
Oct 21, 2023
ionut-arm
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
I need this to load an object created with
tpm2_create.