You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the code will currently work only if called with always-increasing block height only (previous value from cache is always used, ignoring height of block, for which it was calculated). Need to add assert over there, or change cache logic
if cache is empty && database (BlockHeaderProvider) contains blocks, in which some Deployment has activated/failed, this state will be returned for all previous blocks because of this:
since we create separate ChainVerifier for each block AND it takes a lot of time to calculate deployment state, it would be great to use shared cache for ChainVerifier instances. Now cache only works for single block verification.
The text was updated successfully, but these errors were encountered:
Originally code in
support_segwit
branch had a panic here:https://github.com/paritytech/parity-bitcoin/blob/2cacae099ead6b8240a570e4b9226e4007843be5/verification/src/deployments.rs#
This was fixed (temporarily?) by this commit:
9e58d50#diff-39fbf28d89d87ddaff46695c971ec50fR142
But:
parity-bitcoin/verification/src/deployments.rs
Line 96 in 2cacae0
BlockHeaderProvider
) contains blocks, in which someDeployment
has activated/failed, this state will be returned for all previous blocks because of this:parity-bitcoin/verification/src/deployments.rs
Line 102 in 2cacae0
ChainVerifier
for each block AND it takes a lot of time to calculate deployment state, it would be great to use shared cache forChainVerifier
instances. Now cache only works for single block verification.The text was updated successfully, but these errors were encountered: