Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire puppet workers #583

Closed
s0me0ne-unkn0wn opened this issue Aug 8, 2023 · 1 comment · Fixed by #1449
Closed

Retire puppet workers #583

s0me0ne-unkn0wn opened this issue Aug 8, 2023 · 1 comment · Fixed by #1449

Comments

@s0me0ne-unkn0wn
Copy link
Contributor

After worker separation and liberation, puppet workers used for integration tests will not be needed anymore. Their additional functionality (that is only used for those tests) may be integrated into the real workers and gated through #[cfg(test)], as discussed here.

Also, it'd probably open the way for the refactoring of real workers which may be placed into corresponding binary crates in node/core/pvf without the necessity to have separate library and binary crates for every of them.
@mrcnski
Copy link
Contributor

mrcnski commented Aug 8, 2023

Their additional functionality (that is only used for those tests) may be integrated into the real workers and gated through #[cfg(test)]

Good idea, just keep in mind that #[cfg(test)] may not work across crates. (Maybe can instead use the new test-utils feature.)

@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this issue Aug 8, 2023
Open
3 tasks
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@mrcnski mrcnski mentioned this issue Sep 3, 2023
Merged
1 task
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this issue Sep 7, 2023
Merged
s0me0ne-unkn0wn added a commit that referenced this issue Sep 11, 2023
@s0me0ne-unkn0wn
Retire puppet workers (#1449)
2c8021f 
Closes #583

After the separation of PVF worker binaries, dedicated puppet workers
are not needed for tests anymore. The production workers can be used
instead, avoiding some code duplication and decreasing complexity.

The changes also make it possible to further refactor the code to
isolate workers completely.
@mrcnski mrcnski mentioned this issue Sep 27, 2023
Closed
2 tasks
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
c5377b9 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
220e744 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
91208be 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
b313e69 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
d0575cc 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
981537b 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
3931a3f 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
3827ead 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
90afe95 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
6eeedb3 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
8e45257 
* fix grandpa initialization

* fnt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Fix grandpa initialization (paritytech#583)
7c11074 
* fix grandpa initialization

* fnt
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Fix grandpa initialization (#583)
b45d65f 
* fix grandpa initialization

* fnt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retire puppet workers paritytech/polkadot-sdk
2 participants
@mrcnski @s0me0ne-unkn0wn