Skip to content

Commit aad2153

Browse files
committed
fix(css): return undefined if there is no className
1 parent ece9e07 commit aad2153

File tree

9 files changed

+23
-80
lines changed

9 files changed

+23
-80
lines changed

packages/react-core/src/components/List/__tests__/Generated/__snapshots__/ListItem.test.tsx.snap

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
exports[`ListItem should match snapshot (auto-generated) 1`] = `
44
<DocumentFragment>
5-
<li
6-
class=""
7-
>
5+
<li>
86
<span>
97
ReactNode
108
</span>

packages/react-core/src/components/List/__tests__/__snapshots__/List.test.tsx.snap

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -183,23 +183,17 @@ exports[`List inline list 1`] = `
183183
<ul
184184
class="pf-v6-c-list"
185185
>
186-
<li
187-
class=""
188-
>
186+
<li>
189187
<span>
190188
First
191189
</span>
192190
</li>
193-
<li
194-
class=""
195-
>
191+
<li>
196192
<span>
197193
Second
198194
</span>
199195
</li>
200-
<li
201-
class=""
202-
>
196+
<li>
203197
<span>
204198
Third
205199
</span>
@@ -215,23 +209,17 @@ exports[`List ordered list 1`] = `
215209
class="pf-v6-c-list"
216210
type="1"
217211
>
218-
<li
219-
class=""
220-
>
212+
<li>
221213
<span>
222214
Apple
223215
</span>
224216
</li>
225-
<li
226-
class=""
227-
>
217+
<li>
228218
<span>
229219
Banana
230220
</span>
231221
</li>
232-
<li
233-
class=""
234-
>
222+
<li>
235223
<span>
236224
Orange
237225
</span>
@@ -248,23 +236,17 @@ exports[`List simple list 1`] = `
248236
<ul
249237
class="pf-v6-c-list"
250238
>
251-
<li
252-
class=""
253-
>
239+
<li>
254240
<span>
255241
First
256242
</span>
257243
</li>
258-
<li
259-
class=""
260-
>
244+
<li>
261245
<span>
262246
Second
263247
</span>
264248
</li>
265-
<li
266-
class=""
267-
>
249+
<li>
268250
<span>
269251
Third
270252
</span>

packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,6 @@ exports[`Nav Nav List with flyout 1`] = `
10141014
</li>
10151015
</ul>
10161016
<div
1017-
class=""
10181017
data-popper-escaped="true"
10191018
data-popper-placement="right-start"
10201019
data-popper-reference-hidden="true"

packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
exports[`SearchInput advanced search 1`] = `
44
<DocumentFragment>
5-
<div
6-
class=""
7-
>
5+
<div>
86
<div
97
class="pf-v6-c-input-group"
108
>
@@ -145,7 +143,6 @@ exports[`SearchInput advanced search 1`] = `
145143
exports[`SearchInput advanced search with custom attributes 1`] = `
146144
<DocumentFragment>
147145
<div
148-
class=""
149146
data-testid="test-id"
150147
>
151148
<div
@@ -282,7 +279,6 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
282279
</div>
283280
</div>
284281
<div
285-
class=""
286282
data-popper-escaped="true"
287283
data-popper-placement="bottom-start"
288284
data-popper-reference-hidden="true"
@@ -478,9 +474,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
478474

479475
exports[`SearchInput renders search input in strict mode 1`] = `
480476
<DocumentFragment>
481-
<div
482-
class=""
483-
>
477+
<div>
484478
<div
485479
class="pf-v6-c-input-group"
486480
>

packages/react-core/src/components/ToggleGroup/__tests__/__snapshots__/ToggleGroupItemElement.test.tsx.snap

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
exports[`empty 1`] = `
44
<DocumentFragment>
5-
<span
6-
class=""
7-
/>
5+
<span />
86
</DocumentFragment>
97
`;
108

packages/react-core/src/layouts/Flex/__tests__/__snapshots__/Flex.test.tsx.snap

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ exports[`Flex Nested flex 1`] = `
88
<div
99
class="pf-v6-l-flex"
1010
>
11-
<div
12-
class=""
13-
>
11+
<div>
1412
Test
1513
</div>
1614
</div>
@@ -23,9 +21,7 @@ exports[`Flex Simple flex with single item 1`] = `
2321
<div
2422
class="pf-v6-l-flex"
2523
>
26-
<div
27-
class=""
28-
>
24+
<div>
2925
Test
3026
</div>
3127
</div>
@@ -37,9 +33,7 @@ exports[`Flex alternative component 1`] = `
3733
<ul
3834
class="pf-v6-l-flex"
3935
>
40-
<li
41-
class=""
42-
>
36+
<li>
4337
Test
4438
</li>
4539
</ul>

packages/react-drag-drop/src/components/DragDrop/__tests__/__snapshots__/DragDrop.test.tsx.snap

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ exports[`renders some divs 1`] = `
66
class="pf-c-droppable pf-m-dragging"
77
>
88
<div>
9-
<div
10-
class=""
11-
>
9+
<div>
1210
<button
1311
aria-describedby="DndDescribedBy-0"
1412
aria-disabled="false"
@@ -46,9 +44,7 @@ exports[`renders some divs 1`] = `
4644
</button>
4745
one
4846
</div>
49-
<div
50-
class=""
51-
>
47+
<div>
5248
<button
5349
aria-describedby="DndDescribedBy-0"
5450
aria-disabled="false"
@@ -86,9 +82,7 @@ exports[`renders some divs 1`] = `
8682
</button>
8783
two
8884
</div>
89-
<div
90-
class=""
91-
>
85+
<div>
9286
<button
9387
aria-describedby="DndDescribedBy-0"
9488
aria-disabled="false"

packages/react-styles/src/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
*
33
* @param {any} args list of objects, string, or arrays to reduce
44
*/
5-
export function css(...args: any): string {
6-
// Adapted from https://github.com/JedWatson/classnames/blob/master/index.js
5+
export function css(...args: any): string | undefined {
6+
// Adapted from https://github.com/JedWatson/classnames/blob/main/index.js
77
const classes = [] as string[];
88
const hasOwn = {}.hasOwnProperty;
99

@@ -26,5 +26,5 @@ export function css(...args: any): string {
2626
}
2727
});
2828

29-
return classes.join(' ');
29+
return classes.join(' ') || undefined;
3030
}

yarn.lock

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11475,23 +11475,7 @@ __metadata:
1147511475
languageName: node
1147611476
linkType: hard
1147711477

11478-
"glob@npm:^11.0.1":
11479-
version: 11.0.1
11480-
resolution: "glob@npm:11.0.1"
11481-
dependencies:
11482-
foreground-child: "npm:^3.1.0"
11483-
jackspeak: "npm:^4.0.1"
11484-
minimatch: "npm:^10.0.0"
11485-
minipass: "npm:^7.1.2"
11486-
package-json-from-dist: "npm:^1.0.0"
11487-
path-scurry: "npm:^2.0.0"
11488-
bin:
11489-
glob: dist/esm/bin.mjs
11490-
checksum: 10c0/2b32588be52e9e90f914c7d8dec32f3144b81b84054b0f70e9adfebf37cd7014570489f2a79d21f7801b9a4bd4cca94f426966bfd00fb64a5b705cfe10da3a03
11491-
languageName: node
11492-
linkType: hard
11493-
11494-
"glob@npm:^11.0.0":
11478+
"glob@npm:^11.0.0, glob@npm:^11.0.1":
1149511479
version: 11.0.1
1149611480
resolution: "glob@npm:11.0.1"
1149711481
dependencies:

0 commit comments

Comments
 (0)