Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull ENS Avatar After Web3.py Update #11

Open
payton opened this issue Feb 1, 2022 · 5 comments
Open

Pull ENS Avatar After Web3.py Update #11

payton opened this issue Feb 1, 2022 · 5 comments
Labels

Comments

@payton
Copy link
Owner

payton commented Feb 1, 2022

ethereum/web3.py does not yet support the get_text function for ENS.

Pending ethereum/web3.py#2286

@payton payton changed the title Pull ENS Avatar Pull ENS Avatar After Web3.py Update Feb 5, 2022
@payton
Copy link
Owner Author

payton commented Apr 18, 2022

Features merged in ethereum/web3.py#2413

@payton
Copy link
Owner Author

payton commented Aug 29, 2022

TODO

  1. Update
    class ENSProfile:
    """
    Container for ENS profile information including but not limited to primary name and avatar.
    """
    name: str = None
    avatar: str = None
    def __init__(self, ethereum_address: str, w3: Web3):
    # Temporary until https://github.com/ethereum/web3.py/pull/2286 is merged
    self.name = ENS.fromWeb3(w3).name(address=ethereum_address)
    resolver = ENS.fromWeb3(w3).resolver(normal_name=self.name)
    # if resolver:
    # self.avatar = resolver.caller.text(normal_name_to_hash(self.name), 'avatar')
    to pull the avatar text field from an ENS profile
  2. Create an ENSProfile test to assert proper method calls
  3. Validate locally with example app

@payton payton added good first issue Good for newcomers and removed beginner ticket labels Aug 29, 2022
@MatteoMer
Copy link

Hey, I'd love to take this! is it still open?

@payton
Copy link
Owner Author

payton commented Feb 3, 2023

Hey @MatteoMer - that'd be great! Yes, it is still open :)

@payton
Copy link
Owner Author

payton commented Feb 5, 2023

Let me know if you have any questions, @MatteoMer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants