Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that bytes is actually bytes in PDFTextDevice (fixes: #1059) #1069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Nov 27, 2024

This is something of a hack over the underlying problem of #1042 - we declare that a TextSeq contains only int, float, bytes but in no way do we check this. At least we will check it at the point where we actually call something that depends on it being bytes and only bytes.

Fixes: #1059

Tested by finding a PDF in samples/contrib with an identity CMap and putting a name object in the place of a string.

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object of type 'PSKeyword' has no len() via cmapdb.py
1 participant