Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop a redundant final 'l' operator to recognize rectangles #1066

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Drop a redundant final 'l' operator to recognize rectangles #1066

wants to merge 5 commits into from

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Nov 25, 2024 •
edited
Loading

In order to properly recognize rectangles where the path is already closed before the final "h" operator, we detect this and fix it up, since a final "h" is equivalent to a line segment towards the origin of the path. fixes: #1065

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dhdaines dhdaines changed the title Drop redundant final h to recognize rectangles Drop a redundant final 'l' operator to recognize rectangles Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rectangles are misrecognized as curves when they contain a redundant final h operator
1 participant
@dhdaines