Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #40 panic in RESP protocol parser #41

Merged
merged 7 commits into from
Feb 3, 2023
Merged

fix: issue #40 panic in RESP protocol parser #41

merged 7 commits into from
Feb 3, 2023

Conversation

hderms
Copy link
Contributor

@hderms hderms commented Feb 2, 2023

#40

brayniac
brayniac approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@brayniac brayniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice tidy way of preserving my original intent while fixing the unintentional bug here. If we want to change behavior in the future to allow LF instead of CRLF, we can do that separately after more consideration.

@swlynch99 swlynch99 linked an issue Feb 2, 2023 that may be closed by this pull request
Resp protocol parser crashes when given a command ending with a newline #40
Closed
@brayniac brayniac changed the title fix: issue #40 Pelikan panics in RESP protocol parser when given newline delimited GET command fix: issue #40 panic in RESP protocol parser Feb 3, 2023
@brayniac brayniac merged commit 635918e into pelikan-io:main Feb 3, 2023
@hderms hderms deleted the fix/issue_40 branch February 7, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swlynch99 swlynch99 swlynch99 left review comments

@brayniac brayniac brayniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resp protocol parser crashes when given a command ending with a newline
3 participants
@hderms @brayniac @swlynch99