Kotlin 1.7 Support

[chenxiangcxc]

We are trying to upgrade project code to Kotlin 1.7 however PermissionsDispatcher blocks us as it only supports Kotlin 1.5.
Is there any plan to support Kotlin 1.7? Below is the error:

Caused by: java.lang.IllegalArgumentException: Modifiers [PRIVATE] are not allowed on Kotlin parameters. Allowed modifiers: [VARARG, NOINLINE, CROSSINLINE]
	at com.squareup.kotlinpoet.ParameterSpec.<init>(ParameterSpec.kt:41)
	at com.squareup.kotlinpoet.ParameterSpec.<init>(ParameterSpec.kt:29)
	at com.squareup.kotlinpoet.ParameterSpec$Builder.build(ParameterSpec.kt:157)
	at com.squareup.kotlinpoet.FunSpec$Builder.addParameter(FunSpec.kt:500)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createPermissionRequestClass(KotlinBaseProcessorUnit.kt:452)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createPermissionRequestClasses(KotlinBaseProcessorUnit.kt:415)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createFile(KotlinBaseProcessorUnit.kt:43)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createFile(KotlinBaseProcessorUnit.kt:17)
	at permissions.dispatcher.processor.PermissionsProcessor.processKotlin(PermissionsProcessor.kt:68)
	at permissions.dispatcher.processor.PermissionsProcessor.process(PermissionsProcessor.kt:58)
	at org.jetbrains.kotlin.kapt3.base.incremental.IncrementalProcessor.process(incrementalProcessors.kt:90)
	at org.jetbrains.kotlin.kapt3.base.ProcessorWrapper.process(annotationProcessing.kt:197)
	at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:980)

[tommyjackson]

We're using Kotlin 1.7.10 with version 4.9.2 of this library and haven't ran into any issues.

[carterhudson]

But the latest version is 4.8.0... Are you using a snapshot or something?

[tommyjackson]

@carterhudson the Github Releases look like they just haven't been updated. The installation section of the readme says

${latest.version} is maven central 4.9.2

with a link to the releases on maven central

[carterhudson]

Gotcha. It doesn't resolve for me, for some reason.

Edit: ah, package changed.

[carterhudson]

I'm still having the issue when using 4.9.2. It seems like it's due to KModifier.PRIVATE being used here? It's strange, though. It only happens when I try to depend on a certain different dependency.

[carterhudson]

Looks like using Showkase forces the dependency to 1.12.0 where this lib uses 1.[0]3.0?

[ubarua123]

Any updates on this? i am kinda stuck at this point here and 4.9.2 doesn't seem to solve it

[carterhudson]

I have a pr up that fixed it for me in a fork, but this repo seems to be slightly unmaintained.

…

On Fri, Nov 18, 2022, 10:51 PM Udayaditya Barua ***@***.***> wrote: Any updates on this? i am kinda stuck at this point here and 4.9.2 doesn't seem to solve it — Reply to this email directly, view it on GitHub <#775 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATUOEWPZP6W67EVSDD3TCLWJBTGHANCNFSM6AAAAAAQA4RDKU> . You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

[ubarua123]

@carterhudson can you paste the link of your fork? I'll download it, Yeah it looks like this library is unmaintained.

[ubarua123]

Well, the best alternative is, use the com.github.permissions-dispatcher:permissionsdispatcher-ktx version of the library. Works perfect and without the need of annotations.