Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Internal Utilities (Parser, CSSOptimizer) #57

Open
dmtrshat opened this issue Jan 6, 2025 · 0 comments
Open

Unified Internal Utilities (Parser, CSSOptimizer) #57

dmtrshat opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@dmtrshat
Copy link
Member

dmtrshat commented Jan 6, 2025

Description

Refactor the parser and optimizer calls (if necessary) so both the file-based and in-memory code paths reuse as much logic as possible:

  • Parser: Add a new method, e.g., parse_classes_from_string(content: &str) so that the in-memory path doesn’t rely on reading files.
  • Optimizer: Already likely works on a &str basis, so confirm it’s reused seamlessly.

Acceptance Criteria

  1. Parser logic can handle either reading from file-based input paths or directly from string slices (for the new in-memory config).
  2. Duplicated logic is minimized (no separate copy-paste for disk vs. memory).
  3. Confirm code compiles and tests pass for both usage modes.
@dmtrshat dmtrshat added the enhancement New feature or request label Jan 6, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Grimoire CSS Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant