Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code: BlockWritePostponed #2584

Closed
3 tasks done
davidmatson opened this issue Dec 6, 2024 · 1 comment · Fixed by #2597
Closed
3 tasks done

Dead code: BlockWritePostponed #2584

davidmatson opened this issue Dec 6, 2024 · 1 comment · Fixed by #2597

Comments

@davidmatson
Copy link
Contributor

Checklist

What is the issue?

$Context.Configuration.BlockWritePostponed = $true

BlockWritePostponed is set, but according to a code search never read.

Expected Behavior

Dead code is removed

Steps To Reproduce

n/a

Describe your environment

n/a

Possible Solution?

Remove this block from Output.ps1:

 if ($PesterPreference.Output.Verbosity.Value -in 'Detailed', 'Diagnostic') {
        $p.EachBlockSetupStart = {
            $Context.Configuration.BlockWritePostponed = $true
        }
    }
@nohwnd
Copy link
Member

nohwnd commented Dec 12, 2024

Looks like some flag that I planned to use when expanding the names of blocks but never used it because we always postpone the expansion.

Probably good to remove, and see if all tests pass, which I expect will be the case.

davidmatson added a commit to davidmatson/Pester that referenced this issue Jan 2, 2025
@nohwnd nohwnd closed this as completed in 5eba7b6 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants