Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the _SSH from TRUELINE_USER_SHOW_IP_SSH #38

Open
dgtlife opened this issue Mar 29, 2021 · 2 comments
Open

Drop the _SSH from TRUELINE_USER_SHOW_IP_SSH #38

dgtlife opened this issue Mar 29, 2021 · 2 comments

Comments

@dgtlife
Copy link
Contributor

dgtlife commented Mar 29, 2021

The TRUELINE_USER_SHOW_IP_SSH does not appear to be SSH-specific. On my machines, it works like this:

a. When this option is set to "true" on the local machine, the IP address is displayed on the local machine, i.e. IP address in non-SSH mode
b. When one SSHs into a remote host that does not have Trueline installed, the prompt is based on whatever is it was set up to be on that machine.
c. When one SSHs into a remote machine that has Trueline installed, the prompt that one sees in an SSH session on one's local machine is based on whatever the Trueline configuration is on the remote host. If TRUELINE_USER_SHOW_IP_SSH is set to "false", the hostname is shown in the SSH session on local machine.
d. So, as currently implemented TRUELINE_USER_SHOW_IP_SSH affects only the local machine on which it is set, and does not (cannot) affect a remote machine.

So, for clarity the _SSH can be dropped.

@petobens
Copy link
Owner

Makes sense. Please make a pr

@dgtlife
Copy link
Contributor Author

dgtlife commented Mar 31, 2021

Link to the PR #40 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants