Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review UnitConversionProperty and MappedProperty #399

Open
samreid opened this issue Jul 8, 2022 · 0 comments
Open

Review UnitConversionProperty and MappedProperty #399

samreid opened this issue Jul 8, 2022 · 0 comments
Assignees
@jonathanolson
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Jul 8, 2022

In phetsims/chipper#1224 I simplified UnitConversionProperty to address optionize. I noticed there were no usages. I had to ts-ignore the super call because ts was confused. @jonathanolson can you please review UnitConversionProperty and MappedProperty, possibly as part of the upcoming TypeScript sprint?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid