-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tandem.GroupTandem and previous state pattern #477
Comments
I reached out to @jessegreenberg on slack to ask if there is ongoing development in this repo that requires coordination. |
Fixed in the commits. Once I saw an error like "description should be different if something has changed"? in the state wrapper but I couldn't replicate it. This sim is listed in the "Upgrade to Studio" goals for instrumentation, I think that will be an appropriate time for improvements, if necessary. But this seems good enough to close. @zepumph reopen if you recommend a review. |
From phetsims/tandem#87, we need to eliminate usages of
createGroupTandem
. Things should be converted to usePhetioGroup
if necessary. I'll follow the instrumentation guide:The text was updated successfully, but these errors were encountered: