Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issues when editing labelNode.textProperty #349

Open
arouinfar opened this issue Sep 4, 2020 · 1 comment
Open

Layout issues when editing labelNode.textProperty #349

arouinfar opened this issue Sep 4, 2020 · 1 comment

Comments

@arouinfar
Copy link
Contributor

For phetsims/qa#528

Editing the labels on the blocks, beakers, or generator in studio will cause layout issues. As far as I know, the client didn't have an explicit request to edit strings in EFAC , but it is generally something they like to do. I think this looks pretty bad, and it would be nice if the strings could be re-centered based on their new size.

General studio string issues are on the phet-io meeting agenda, and I will add a link to this issue as an example. @jbphet I don't know if there is much to do before then, but I'm going to assign you so you are aware of this issue.

image
image

image
image

@jbphet
Copy link
Contributor

jbphet commented Sep 11, 2020

In the 9/10/2020 phet-io meeting, we decided that adding dynamic layout code that handles in situ changes to the strings is overkill given what we expect our users to do, and that we'd be better off creating a means through which users can customize strings prior to the sim's launch. Our plan is to add this in the future, but we won't do so before the imminent 1.4 release. So, the plan for now is not to address the layout problems described above unless there is a specific request from the first users of the phet-io version of the sim. I will defer this issue for now, and revive it if we need to.

If no requests for dynamic layout support are ever received, this issue can be closed once support for changing strings exists in Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants