Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track overlaps and skater goes in front of energy graph #110

Closed
jaspearias opened this issue Aug 13, 2019 · 3 comments
Closed

Track overlaps and skater goes in front of energy graph #110

jaspearias opened this issue Aug 13, 2019 · 3 comments
Assignees
Labels

Comments

@jaspearias
Copy link

Test Device

Hanson

Operating System

Windows 10

Browser

Internet Explorer

Problem Description

For phetsims/qa#397
In the Lab screen when customizing your own track the track overlaps the box with the friction/mass/gravity sliders. The track also goes behind the energy graph but the the skater stays in front of it.

Visuals

https://drive.google.com/file/d/1SYx1Yes9uWHE8j_dgIaf68C4pbWpc732/view?usp=sharing

@arouinfar
Copy link
Contributor

Good find @jaspearias.

@jessegreenberg I think the tracks and skater should be layered above everything, including the bar graph.

This behavior would be fairly consistent with the published version of ESPB, though the z-ordering of the Bar Graph is a bit wonky there. (It also predates the griddle work.)
image

@jessegreenberg
Copy link
Contributor

The layering of the sim as it is in the published version was a previous requirement of using WebGL. But now that we are no longer using WebGL, we should be able to layer however we wish! I will move the tracks and skater above everything.

@jessegreenberg
Copy link
Contributor

OK, the layering has been changed so that the skater and tracks are above all non-interactive components. For the measure screen, the layering order is

  • tracks
  • skater path
  • skater path sensor
  • measuring tape
  • skater

so that the measuring tape cannot get hidden behind the skater path sensor and the sensor and skater look good on top of the measurable skater path. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants