Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised tracks now cover graph #189

Closed
KatieWoe opened this issue Feb 5, 2020 · 5 comments
Closed

Raised tracks now cover graph #189

KatieWoe opened this issue Feb 5, 2020 · 5 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 5, 2020

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#470. Related to #115, which involves extending the fixed track on the graphs screen by continually manipulating the three point track under the ground to push it up. This was decided to not be fixed. However, the tracks now layer on top of, instead of beneath, the graph. This looks much more odd and could pose more of a problem.
Steps to reproduce
Same as #115

Visuals
trackinfront

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Energy Skate Park‬
URL: https://phet-dev.colorado.edu/html/energy-skate-park/1.0.0-dev.6/phet/energy-skate-park_en_phet.html
Version: 1.0.0-dev.6 2020-01-27 21:28:50 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@jessegreenberg
Copy link
Contributor

Thanks @KatieWoe, ill take a look.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 5, 2020

Interestingly it does stop going up at a certain point:
stopsgoingup

@jessegreenberg
Copy link
Contributor

Thanks for verifying! We did decide to fix this, it is just that the limiting bounds are too large for the graphs screen. Can you please check to see if this is fixed in master?

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 5, 2020

Looks fixed in master

@KatieWoe KatieWoe assigned jessegreenberg and unassigned KatieWoe Feb 5, 2020
@jessegreenberg
Copy link
Contributor

Great, thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants