Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT Error - phetioElement not found: energySkatePark.measureScreen.measureScreenView.trackNodeGroup.archetype.controlPointNode0 #318

Closed
jessegreenberg opened this issue Jan 25, 2021 · 4 comments

Comments

@jessegreenberg
Copy link
Contributor

No description provided.

@jessegreenberg jessegreenberg self-assigned this Jan 25, 2021
@jessegreenberg jessegreenberg changed the title CT Error: phetioElement not found: energySkatePark.measureScreen.measureScreenView.trackNodeGroup.archetype.controlPointNode0 CT Error - phetioElement not found: energySkatePark.measureScreen.measureScreenView.trackNodeGroup.archetype.controlPointNode0 Jan 25, 2021
@jessegreenberg
Copy link
Contributor Author

I am not sure, but I think this may be related to #123 - Maybe the ControlPointNodes of TrackNode need to use PhET-iO group as well? Maybe this isn't compatible with changes in #123.

tandem.createTandem( 'controlPointNode' + i )

@samreid what do you recommend, should I try PhetioGroup or do you think the issue is somewhere else?

@samreid
Copy link
Member

samreid commented Jan 25, 2021

This seems related to work I've done in the last few days, I'll take a look.

@samreid
Copy link
Member

samreid commented Jan 26, 2021

I disabled phet-io validation for energy-skate-park-basics until we enable it for both energy-skate-park as well.

@samreid
Copy link
Member

samreid commented Jan 26, 2021

The problem seems to be that the archetype only had 2 control points, but the actual track had 3, so it failed to see that last control point. For now I've solved this by increasing the number of control points in the archetype. I'm not sure if the long term solution is to use a PhetioGroup for the archetype. It's working on my local side, and we may need to defer the long term solution until we are focusing more on next phet-io publication for these sims. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants