Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic locales #350

Open
jessegreenberg opened this issue Nov 30, 2022 · 2 comments
Open

Add support for dynamic locales #350

jessegreenberg opened this issue Nov 30, 2022 · 2 comments
Labels
priority:5-deferred

Comments

@jessegreenberg
Copy link
Contributor

Discussed on slack with @arouinfar that this is probably not needed for the upcoming publication. But it may be quick to add before we start a dev test this week. Ill give it a try but bail if it takes more than an hour today.
@jessegreenberg jessegreenberg self-assigned this Nov 30, 2022
@jessegreenberg jessegreenberg mentioned this issue Nov 30, 2022
Closed
jessegreenberg added a commit that referenced this issue Nov 30, 2022
@jessegreenberg
converte to StringProperty, see #350
66f6b2c
@jessegreenberg
Copy link
Contributor Author

I converted everything to string Properties but there is going to be a lot more to be a lot more work required to support dynamic layout. I can't take this on at the moment so Ill stop working on this until it is requested.

jessegreenberg added a commit that referenced this issue Dec 1, 2022
@jessegreenberg
remove supportsDynamicLocales for now, see #350
903ed04
@jessegreenberg jessegreenberg removed their assignment Dec 1, 2022
@jessegreenberg jessegreenberg mentioned this issue Dec 6, 2022
Open
@jessegreenberg
Copy link
Contributor Author

During status meeting today it was confirmed that publication for region/culture does not need to include dynamic locales.

@jessegreenberg jessegreenberg mentioned this issue Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @marlitas