Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graphs Screen] Layout for speedometer #88

Closed
jessegreenberg opened this issue Aug 5, 2019 · 5 comments
Closed

[Graphs Screen] Layout for speedometer #88

jessegreenberg opened this issue Aug 5, 2019 · 5 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

The mockups for the graph screen show a "Speed" checkbox but no speedometer. The default position for the speedometer is right behind the "Energy Graph" accordion box, so the speedometer is hidden when the accordion box is open. Do we need to fit the speedometer somewhere else in this screen?

@arouinfar
Copy link
Contributor

From #106:

Problem Description

For phetsims/qa#397. In the "Graphs" screen, the speedometer is stuck behind the energy graph. Part of the speedometer is cut off by the energy graph. The energy graph is open by default, so by default it looks like checking the speedometer checkbox doesn't do anything.

Visuals
Screen Shot 2019-08-12 at 3 41 51 PM

@jessegreenberg
Copy link
Contributor Author

@arouinfar will consider this. We thought about making it a bit smaller and putting it in the lower left of the screen around the mountains in the background.

@arouinfar
Copy link
Contributor

@jessegreenberg let's try this layout

image

@jessegreenberg
Copy link
Contributor Author

Done above. I didn't have to change the size of the speedometer and it still seems to match what you have in #88 (comment). Not sure if you adjusted the size at all for this screen. How does master look? Let me know if you want it any smaller.

@arouinfar
Copy link
Contributor

Looks good in master @jessegreenberg. I like the consistency of keeping it the same size across screens, so let's leave it as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants