Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design review #99

Closed
arouinfar opened this issue Aug 7, 2019 · 2 comments
Closed

Design review #99

arouinfar opened this issue Aug 7, 2019 · 2 comments
Assignees
@arouinfar
Labels
design:polish

Comments

@arouinfar
Copy link
Contributor

Related to phetsims/qa#397, but likely won't get done until after QA is finished.

I should review the design and see if there are any inconsistencies or pixel polishing that needs to be done.
@arouinfar arouinfar self-assigned this Aug 7, 2019
@JRomero0613
Copy link

@arouinfar When testing for phetsims/qa#397 I noticed on the Graphs screen that the "Position" graph x-axis is labeled as "Time (s)". If I'm not mistaken it should be labeled "Position (m)".

@arouinfar
Copy link
Contributor Author

Thanks @JRomero0613. I'm seeing the correct axis labelling in master, so I think it must have been corrected.

Pixel polishing is being handled in #240, so I'm going to go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:polish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arouinfar @JRomero0613