-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to new pattern for mixin/traits #154
Comments
3/4/21 dev meeting. We discussed concerns about mixins. @samreid mentioned lack of IDE support, which is the case for the new and old patterns. @samreid suggested that we investigate using compostion instead of mixins. Here's an article that enumerates pitfalls of mixin, and discusses moving from mixins to "automated composition": We ran out of time, and decided to resume discussiion of this issue later. |
Discussed during 3/4/21 meeting - JO: There is an issue with the new pattern for mixin/trait where there isn't IDE support. Sounds like there are loose ends still and we aren't ready to move forward with the new pattern yet. We will pick it up next time. |
Looks like we are not in the "now we convert" phase here, I will note that perhaps #143 is the better issue to discuss this in. Unassigning. |
@pixelzoom had the right idea over in #143 (comment)! Unmarking for dev meeting. On hold until we finish discussion over there. |
From #143, here is the list of mixins and traits in the project that we should update to use the "new" pattern. See
Popupable
as an example of the new, es6 style of mixin/trait creation.using
mixInto:
as a searchusing "compose" as a search
Marking for dev meeting as a chip away.
The text was updated successfully, but these errors were encountered: