Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to new pattern for mixin/traits #154

Open
8 tasks
zepumph opened this issue Feb 11, 2021 · 4 comments
Open
8 tasks

Convert to new pattern for mixin/traits #154

zepumph opened this issue Feb 11, 2021 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Feb 11, 2021

From #143, here is the list of mixins and traits in the project that we should update to use the "new" pattern. See Popupable as an example of the new, es6 style of mixin/trait creation.

using mixInto: as a search

  • Paintable.js
  • Poolable.js
  • Leaf.js
  • AccessibleNumberSpinner.js
  • AccessibleSlider.js
  • AccessibleValueHandler.js
  • ValueGestureControl.js

using "compose" as a search

  • ParallelDOM.js

Marking for dev meeting as a chip away.

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 4, 2021

3/4/21 dev meeting.

We discussed concerns about mixins. @samreid mentioned lack of IDE support, which is the case for the new and old patterns.

@samreid suggested that we investigate using compostion instead of mixins. Here's an article that enumerates pitfalls of mixin, and discusses moving from mixins to "automated composition":
https://raganwald.com/2016/07/20/prefer-composition-to-inheritance.html

We ran out of time, and decided to resume discussiion of this issue later.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Mar 4, 2021

Discussed during 3/4/21 meeting -

JO: There is an issue with the new pattern for mixin/trait where there isn't IDE support.
SR: Maybe we should transtion away from mixins?
MK: If IDE support is the only bad part of this, can we make our own pluggin to support it?

Sounds like there are loose ends still and we aren't ready to move forward with the new pattern yet. We will pick it up next time.

@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2021

Looks like we are not in the "now we convert" phase here, I will note that perhaps #143 is the better issue to discuss this in. Unassigning.

@zepumph zepumph removed their assignment Mar 4, 2021
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2021

@pixelzoom had the right idea over in #143 (comment)! Unmarking for dev meeting. On hold until we finish discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants