New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-repos-list.js doesn't clean up if it fails. #183

Open

pixelzoom opened this issue Feb 22, 2022 · 0 comments

Assignees

Labels

Contributor

pixelzoom commented Feb 22, 2022

In #180 (comment), @mattpen said:

FYI, running the script also create an unversioned file in my local working copy: phet-info/github-labels/.repos.old.

That file should get removed if update-repos-list.js finishes successfully.

phet-info/github-labels/update-repos-list.js

Lines 47 to 48 in 91574b2

// Clean up

await fs.promises.unlink( '.repos.old' );

In general, scripts/programs should clean up files regardless of whether they encounter errors.

pixelzoom added the priority:4-low label

pixelzoom assigned mattpen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment