Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev-Lite Test: Energy Skate Park 1.3.0-dev.2 #1196

Closed
4 of 11 tasks
samreid opened this issue Jan 16, 2025 · 10 comments
Closed
4 of 11 tasks

Dev-Lite Test: Energy Skate Park 1.3.0-dev.2 #1196

samreid opened this issue Jan 16, 2025 · 10 comments
Assignees
Labels
QA:dev-lite Early, short dev test

Comments

@samreid
Copy link
Member

samreid commented Jan 16, 2025

Dev-Lite Test

Mentions: @kathy-phet @KatieWoe @arouinfar

Simulation links

Test Matrix

  • Tester 1 (Tester = NS , Platform = mac + safari , Time = 2
  • Tester 2 (Tester = KW, Platform = Win 11 Chrome, Time = 1.5 {max 2 hours}

Features included

  • PhET-iO (only save/load state for now)
  • Dynamic Locale @samreid - This sim will require dynamic locale to meet PhET Studio requirements - so add that.
  • Alternative Input
  • UI Sound
  • Sonification
  • Description
  • Voicing
  • Region and Culture

Focus and Special Instructions

We are interested in getting Energy Skate Park set up so it can run in PhET Studio. The sim has been ported to TypeScript
and we worked on issues that were crashing the PhET-iO State wrapper or Studio => Test.

So this test should check the PhET brand version to look for any emergent bugs from the TS conversion.
Also test the PhET-iO save/load state capability to ensure that functionality is working .

To test state, set up certain scenarios in PhET-iO Studio (without using hide/show or anything fancy), then pressing "Test" then make sure the loaded "Test" simulation is correctly interoperable. The same can be tested in the PhET-iO State wrapper if you adjust the set state rate to 0 use the "Set State" button.

We are starting with a dev-lite to ensure we are in a good place to continue development.

Issues to Verify

These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

  • Please specify any credits changes to make

For QA...

General features

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@samreid samreid added the QA:dev-lite Early, short dev test label Jan 16, 2025
@samreid samreid changed the title Dev Test: Energy Skate Park 1.3.0-dev.2 Dev-Lite Test: Energy Skate Park 1.3.0-dev.2 Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Upcoming Tests (by priority) in QA Pipeline Jan 16, 2025
@samreid samreid moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Jan 16, 2025
@samreid
Copy link
Member Author

samreid commented Jan 16, 2025

Oops, miscommunication on my part in phetsims/energy-skate-park#385 (comment), let's cancel this for now. Thanks!

@samreid
Copy link
Member Author

samreid commented Jan 16, 2025

At PhET-iO meeting today, we agreed this is at a good point for a dev-lite test.

@KatieWoe KatieWoe moved this from Done to Active Tests (max 5, by priority) in QA Pipeline Jan 16, 2025
@Nancy-Salpepi
Copy link
Contributor

@samreid I noticed that there is an update available. Should I ignore that and test 1.3.0?

Image

@samreid
Copy link
Member Author

samreid commented Jan 16, 2025

It looks like the version did not get bumped when 1.3 was released. I'll open an issue for it. This test should remain testing 1.3.0-dev.2.

@kathy-phet
Copy link

@Nancy-Salpepi @KatieWoe - To clarify on this test, we are mainly looking for any bugs introduced due to the typescript conversion that occured. PhET-iO testing should be pretty light. The PhET-iO instrumentation will get a relatively major overhaul to be brought up to speed with current naming convensions and removing over instrumentation and such, this work has not been done.

So focus on

  • testing the PhET brand sim looking for any bugs, slow downs, inconsistencies from the public published version that might have cropped in
  • testing just the save state portion of PhET-iO in the state wrapper.

Do not do any testing beyond that for PhET-iO, as signficant changes will come. The comment about moving directly to RC testing is not accurate, based on the conversation we had in todays meeting so I will edit that out.

@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Jan 17, 2025
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Dev & RC: ready for next steps in QA Pipeline Jan 17, 2025
@mattpen
Copy link
Contributor

mattpen commented Jan 17, 2025

I've got a very basic way to test things in PhET Studio. Just follow the instructions at https://github.com/phetsims/phet-studio/?tab=readme-ov-file#studio-sandbox, then when you open the app in localhost, it should give further instructions for launching the dev version in the Studio Sandbox.

You will need to enter this information in the sandbox launcher:
Simulation: energy-skate-park
Version (major.minor): 1.3
PhET-iO Lib Url: https://phet-dev.colorado.edu/html/energy-skate-park/1.3.0-dev.2/phet-io/lib/phet-io.js

This is the first time that anyone other than @chrisklus or myself have used this app, so please reach out to us with any questions/comments/concerns/feedback.

@zepumph
Copy link
Member

zepumph commented Jan 17, 2025

@mattpen @chrisklus and I don't feel like the above seems too reasonable for QA to do. Let's pick up that part over in https://github.com/phetsims/phet-studio/issues/8.

@mattpen
Copy link
Contributor

mattpen commented Jan 17, 2025

You should now be able to use https://bayes.colorado.edu/studio-sandbox/ to enter the following data and test this dev version:

Simulation: energy-skate-park
Version (major.minor): 1.3
PhET-iO Lib Url: https://phet-dev.colorado.edu/html/energy-skate-park/1.3.0-dev.2/phet-io/lib/phet-io.js

I don't know if this issue still needs to be tested or if we want to try this out on the next dev test instead.

@samreid
Copy link
Member Author

samreid commented Jan 17, 2025

Hoping to test studio-sandbox on Forces and Motion in an upcoming test. Can this one be closed?

@samreid samreid closed this as completed Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Dev & RC: ready for next steps to Done in QA Pipeline Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-lite Early, short dev test
Projects
Status: Done
Development

No branches or pull requests

6 participants