Support dynamic layout for changing locales

[zepumph]

No description provided.

[zepumph]

From a first pass, here is what it seems like we still will need to do:

• Support accessibleName, innerContent, and labelContent
• Support Voicing responses
• Support Keyboard help dialog common code
• Support AccordionBox title with dynamic layout

[zepumph]

Another pass after phetsims/scenery#1442, in general it isn't going to be easy to convert describers, it is just a lot of content that is depending on strings. I don't think I'm going down that path.

[samreid]

I pushed a workaround for a type error:

tsc: ../../../ratio-and-proportion/js/create/CreateScreen.ts(31,9): error TS2322: Type 'TReadOnlyProperty<string>' is not assignable to type 'string'.

[zepumph]

I just realized that this effects the PhET brand too, because the all HTML will have a localization tab, so I think I need to support this generally.

[zepumph]

• Make sure we are disposing these texts now, see Memory leaks introduced by dynamic strings scenery-phet#771

[zepumph]

From a conversation with @jonathanolson:

• When scaling: look at localBounds because those don't account for scale.
• Use Aliginbox/VBox or maybe a Manual constraint to make sure the layout scaling nodes are good.

[zepumph]

Noting we should work on phetsims/scenery-phet#769 to get this done too.

[zepumph]

I punted quite a few times, please search for StringProperty.value to complete this work for description/voicing.

[zepumph]

Good progress today.

[zepumph]

Alright. I believe that we are unblocked here. The above two checkboxes in #499 (comment) have TODOs pointing here, and could be worked on in the future if desired, but I sorta feel like it isn't every going to be worth the effort, and we should apply the new patterns in the new description sims we implement.

[zepumph]

QA (@KatieWoe), can you please review the work done in this issue:

I was using https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.32/phet/ratio-and-proportion_all_phet.html?keyboardLocaleSwitcher&dev&locales=* and ctrl + U/I helped test this a lot. Please ensure the below issues are resolved in this sim.

• Some strings are no longer translated #515
• Translations may now overlap objects or be too long to be fully shown #516
• Keyboard help dialog supports dynamic locale switching.

[KatieWoe]

keyboard help dialog supports dynamic locale switching.

For this section I found several potential issues. There were many more than pictured here.
First, some buttons were blank.

Second, some text in buttons go beyond their edges.

[KatieWoe]

#515 also still has a problem. Sending this back to you @zepumph. Testing was done on the provided dev version.

[zepumph]

I think I fixed keyNode here,

Can you give it another shot? I'm not sure why hebrew had blank keys.

[KatieWoe]

The overlapping looks much better. There are one or two other languages that also have blank keys btw.

[zepumph]

I created phetsims/scenery-phet#786 for the blank keys. Closing. Please reopen if you feel differently.

[phet-dev]

Reopening because there is a TODO marked for this issue.

[zepumph]

Moved todos to #552. Closing