Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch mutations to PDOM elements #1439

Open
zepumph opened this issue Aug 8, 2022 · 0 comments
Open

Batch mutations to PDOM elements #1439

zepumph opened this issue Aug 8, 2022 · 0 comments

Comments

@zepumph
Copy link
Member

zepumph commented Aug 8, 2022

From #1436:

Look into batching attribute setting to a single time per frame. (right now it is often based on model Properties, and may involve multiple, synchronous, DOM operations per frame. I'm not positive this is the case; it will need more investigation.

I think this would greatly help our performance in PDOM-heavy interactions. For example phetsims/ratio-and-proportion#356.

I'm not sure how hard it would be to create a space where ParallelDOM instances are marked as dirty, or even sections of it are marked as dirty. I'm nervous about this issue, because I think it could be pretty prone to regressions and destructive to implement. I will see if we want to devote time to this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant