Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO: too many instrumented containers #888

Open
zepumph opened this issue Jul 8, 2024 · 0 comments
Open

PhET-iO: too many instrumented containers #888

zepumph opened this issue Jul 8, 2024 · 0 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 8, 2024

Over in phetsims/density-buoyancy-common#251 @samreid @AgustinVallejo and I would have liked to have been able to provide a tandem to ToggleNode just for its group items, and not instrument the ToggleNode class parent. This is not supported here, and not supported generally. This pattern often leaves a lot of extra and unnecessary instrumentation in published sims, like NodeIO instances.

We think this may be the biggest problem for common code that uses getGroupItemNodes because that pattern is prone to needing the group items instrumented at the cost of instrumenting the parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant