Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "expand/collapse button with label". #919

Open
pixelzoom opened this issue Dec 3, 2024 · 0 comments
Open

Create "expand/collapse button with label". #919

pixelzoom opened this issue Dec 3, 2024 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 3, 2024

In phetsims/fourier-making-waves#254, we identified a need for a "expand/collapse button with label" in order to properly support alt input features. For example:

screenshot_3626

Clicking on either the button or label should toggle the Property associated with the ExpandCollapseButton.

Focus highlight should surround both the button and label, and tab traversal should not visit the ExpandCollapseButton invidually.

Interactive highlight should similarly surround both the button and label.

This is not blocking for phetsims/fourier-making-waves#254.

Note that fourier-making-waves currently includes LabeledExpandCollapseButton, which might be used as a starting point -- but the label should be generalized to any type of Node. Creating such a subclass seems preferrable to adding yet-another option to ExpandCollapseButton.

@pixelzoom pixelzoom changed the title Create "labeled expand/collapse button". Create "expand/collapse button with label". Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant