Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic locales #100

Open
jessegreenberg opened this issue Nov 21, 2024 · 1 comment
Open

Support dynamic locales #100

jessegreenberg opened this issue Nov 21, 2024 · 1 comment
Assignees
@amanda-phet
Labels
type:i18n

Comments

@jessegreenberg
Copy link
Contributor

We want to support this in #98, lets re-do the layout so that it is supported.
@jessegreenberg jessegreenberg self-assigned this Nov 21, 2024
@jessegreenberg jessegreenberg mentioned this issue Nov 21, 2024
Open
jessegreenberg added a commit that referenced this issue Dec 9, 2024
@jessegreenberg
progress for dynamic locales, see #100
ec34c96
jessegreenberg added a commit that referenced this issue Dec 9, 2024
@jessegreenberg
dynamic layout support for #100
79d565a
jessegreenberg added a commit that referenced this issue Dec 10, 2024
@jessegreenberg
dynamic layout for the values panel, see #100
2e5f755
jessegreenberg added a commit that referenced this issue Dec 10, 2024
@jessegreenberg
lint fixes for #100
c8067bc
jessegreenberg added a commit that referenced this issue Dec 10, 2024
@jessegreenberg
dynamic layout for control panel, see #100
216d97c
jessegreenberg added a commit that referenced this issue Dec 10, 2024
@jessegreenberg
dynamic layout for unit circle view labels, see #100
6148a43
jessegreenberg added a commit that referenced this issue Dec 12, 2024
@jessegreenberg
dynamic layout for the radians units, see #100
e44da66
jessegreenberg added a commit that referenced this issue Dec 12, 2024
@jessegreenberg
dynamic locales for #100
6b470fa
jessegreenberg added a commit that referenced this issue Dec 12, 2024
@jessegreenberg
dynamic layout for the units radio buttons, see #100
3ef00dd
@jessegreenberg
Copy link
Contributor Author

OK, I think this is done. It was a little tricky because of the math symbols and equations in the "Values" panel and graphs. @amanda-phet can you please review that the layout is OK after these changes and with ?stringTest=dynamic? Is this ready to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-phet amanda-phet

Labels
type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @amanda-phet