-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future suggestions from Susan #80
Comments
I can't track down a design decision explicitly outlining this, but I think the general idea was to display special angles in this way so they'd recognize 7π/6 (for example) and not need to do a calculation with fractions to see that 151/6 is the same as a multiple of π + 7/6. I am not worried about "giving away" the idea of an angle greater than 360º or 2π having the same trig values, since that is the goal of this sim.
This would require some redesign since these radio buttons change the values, the unit circle representation, and the graph representation. We'd need to figure out how to handle this in the Values accordion box and on the unit circle.
I think this would be really great, and not hard to add, but again would require some design time.
This seems like a separate screen, IMO. @kathy-phet can you let me know if you think it would be ok to pursue some of these design changes? |
@kathy-phet and I discussed this (1) To address this goal, we would like to change how 3π, 5π, etc. are displayed. To address the confusion, we should labels those as 2π + π, 4π + π, etc. rather than simplifying those values. (2) This would require substantial design time, although we think it's possible to fit all three function values in the Values accordion box, and all three graphs could fit at the same time. We'd like to defer this for now. However, a simpler redesign to support this goal would be to add legend icons next to the function radio button labels (colored lines). (3) We love this idea, but it also feels like something that should go as a separate tangent view, and/or something in the preferences (e.g. "Right Triangle Trig"). Defer for now. (4) This sounds like a separate "transformations" sim, which could be great, but not appropriate for the scope of this publication. @jessegreenberg can you go ahead and make the changes described in (1) and (2)? |
These are done, @amanda-phet can you please make sure 1 is working correctly and comment on improvements for 2? For 1 - The easiest way to do this was to use a string for this custom representation. For negative angles, it looks something like For 2 - It looks like this, any layout adjustements or anything else? |
I wasn't aware of em dash thanks! That did look better, but wasn't quite the same as the custom line drawn by the fraciton Nodes. I ended up changing this so that it uses FractionNode instead. Is there anything else needed for this issue? |
Susan had the following future suggestions
The text was updated successfully, but these errors were encountered: