Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build packs with piles sorted alphabetically as an option, not default #94

Open
rinaldijuw opened this issue Mar 31, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@rinaldijuw
Copy link

(tested on PC)
I entered my piles according to the way I prepared it WUBRG-Gold-Colorless-lands, but when I create packs, it automatically sorted the piles alphabetically. So when I began to build packs I was a little thrown off (it turned into Black Blue Colorless Green Lands Multicolor Red White)

I would love it if sorting alphabetically is an option (and not the default).
Perhaps a tickbox option when creating packs (sort piles A --> Z)

Thanks for building this!
@rinaldijuw

@philipborg
Copy link
Owner

That sounds like a very nice feature. Shouldn't be too hard to implement. I think the following should be implemented for this feature.

  1. Add a drop-down menu on the pack view with ordering options for pile names in packs. One option would be "Custom", which would be user chosen.
  2. Add some way to choose ordering of "Custom" in the pile view, so it's not just ordered as entered. Drag and drop would be the best, but it's frankly such a pain to implement so buttons may have to suffice as to not consume too much dev-time. (Time that could be spent on other issues first, then if there is spare time it can be added.)

Splitting this to two steps allows value to be delivered earlier.

Thanks for your appreciation, feedback and suggestion!

Implementation detail:
Would probably need to switch some HashMap's to IndexMap.

@philipborg philipborg added the enhancement New feature or request label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants