Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runner): support Ubuntu 24.04 #4246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(runner): support Ubuntu 24.04 #4246

wants to merge 2 commits into from

Conversation

bdellegrazie
Copy link

@bdellegrazie bdellegrazie commented Nov 8, 2024 •
edited
Loading

On Ubuntu 24.04 there is another variable ID_LIKE that appears in the /etc/os-release file. This change fixes the regex to only match ID and not ID_LIKE

closes #4245

@npalm npalm self-requested a review November 10, 2024 09:44
@bdellegrazie
Copy link
Author

Additional change to the user data template to make the Ubuntu example work.

@npalm npalm changed the title fix(runner-install): correct detection of Ubuntu 24.04 feat(runner): support Ubuntu 24.04 Nov 15, 2024
npalm
npalm reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdellegrazie great to see support for ubuntu 24.04 is coming in. What is the status of the PR? How did you test the PR. Is the cahnge working as well for ubuntu 22.04

@npalm
Copy link
Member

npalm commented Nov 15, 2024

Just testing the setup on ubuntu 22.04, works all fine. Still curious if there are any side effects.

Are you also aware we thinking about update the module to support ubuntu by default, and step away from Amazon. Interally we are already 1.5 year on Ubuntu (own ami). Would be great if we can add via a second PR support for arm as well.

I have updated the examples, will push them asap.

@npalm
Copy link
Member

npalm commented Nov 15, 2024

Getting the following error / warning in the log for ubuntu 24.0, however the runner gets healthy online and is being able run jobs.


No VM guests are running outdated hypervisor (qemu) binaries on this host.
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.1$
E: Couldn't find any package by glob 'libssl1.1$'
E: Couldn't find any package by regex 'libssl1.1$'
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.0.2$
E: Couldn't find any package by glob 'libssl1.0.2$'
E: Couldn't find any package by regex 'libssl1.0.2$'
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.0.0$
E: Couldn't find any package by glob 'libssl1.0.0$'
E: Couldn't find any package by regex 'libssl1.0.0$'
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu72
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu71
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu70
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu69
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu68
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu67
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu66
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu65
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu63
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu60
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu57
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu55
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libicu52

@npalm
Copy link
Member

npalm commented Nov 15, 2024

I have pushed changes on the example dir to this branch

@npalm
Copy link
Member

npalm commented Nov 15, 2024

In summary:

  • multi-runner example contains an ubuntu2404
  • really nice contribution 🚀
  • would be great when you can add some details about choices in changes in the user_data example

@bdellegrazie
Copy link
Author

bdellegrazie commented Nov 16, 2024 •
edited
Loading

Getting the following error / warning in the log for ubuntu 24.0, however the runner gets healthy online and is being able run jobs.


No VM guests are running outdated hypervisor (qemu) binaries on this host.
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.1$
E: Couldn't find any package by glob 'libssl1.1$'
E: Couldn't find any package by regex 'libssl1.1$'
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.0.2$
E: Couldn't find any package by glob 'libssl1.0.2$'
E: Couldn't find any package by regex 'libssl1.0.2$'
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libssl1.0.0$
E: Couldn't find any package by glob 'libssl1.0.0$'
E: Couldn't find any package by regex 'libssl1.0.0$'
Reading package lists...

@npalm : libssl is called libssl3t64 in Ubuntu 24.04. It is possible their installation script doesn't account for that.

@bdellegrazie
Copy link
Author

@npalm I have responded to your questions, please let me know if you require any more information.
Thanks!

@npalm
Copy link
Member

npalm commented Nov 18, 2024

@bdellegrazie will check later this week.

@npalm npalm self-requested a review November 18, 2024 16:41
npalm
npalm requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, tested and works all nice, small remark on the docs.

examples/multi-runner/README.md Outdated Show resolved Hide resolved
@bdellegrazie bdellegrazie force-pushed the fix/ubuntu-24.04 branch 2 times, most recently from 65b9267 to 410a7aa Compare November 21, 2024 07:47
@bdellegrazie bdellegrazie requested a review from npalm November 21, 2024 07:47
@bdellegrazie
Copy link
Author

@npalm I have made the change as requested - could you please re-review?

@bdellegrazie
fix(runner-install): correct detection of Ubuntu 24.04
5cb7209 
On Ubuntu 24.04 there is another variable `ID_LIKE` that appears in
the `/etc/os-release` file. This change fixes the regex match
to only match ID and not ID_LIKE

closes philips-labs#4245
@bdellegrazie
fix(ubuntu-24.04): make Ubuntu example work
e62b83d 
* Switch to using the upstream deb archive for Docker
* use awscli v2
* Provide a user-specific override for systemd
* use machinectl to launch rootless docker
@bdellegrazie
Copy link
Author

@npalm rebased, could you please re-review and merge?

@npalm
Copy link
Member

npalm commented Nov 28, 2024

@npalm rebased, could you please re-review and merge?

Yup, but agenda is packed. Hope to process all outstanding prs next week.

@npalm
Copy link
Member

npalm commented Dec 6, 2024

I thought, I pushed examples to the branch. But maybe I am wrong. Need to find my examples back for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgp1701 davidgp1701 davidgp1701 approved these changes

@npalm npalm Awaiting requested review from npalm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ubuntu noble 24.04 fails due to regex
3 participants
@bdellegrazie @npalm @davidgp1701