From 639a71942be337ad3adf37b663c943d3f684290b Mon Sep 17 00:00:00 2001 From: Bailey Date: Sun, 31 Dec 2023 10:21:30 -0600 Subject: [PATCH] [580] fix: Console Client couldn't load configuration file correctly (introduced by #564) (#584) --- mkdocs/docs/configuration/json.md | 4 ++-- src/Common/Configuration.cs | 4 ++-- vNextReleaseNotes.md | 5 +++++ 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/mkdocs/docs/configuration/json.md b/mkdocs/docs/configuration/json.md index 8d1797225..4df12c5b7 100644 --- a/mkdocs/docs/configuration/json.md +++ b/mkdocs/docs/configuration/json.md @@ -193,7 +193,7 @@ This section provides settings related to fetching workouts from Peloton. | Field | Required | Default | UI Setting Location | Description | |:-----------|:---------|:--------|:--------------------|:------------| | Email | **yes** | `null` | `Peloton Tab` | Your Peloton email used to sign in | -| Password | **yes** | `null` | `Peloton Tab` | Your Peloton password used to sign in | +| Password | **yes** | `null` | `Peloton Tab` | Your Peloton password used to sign in. **Note: Does not support `\` character in password** | | NumWorkoutsToDownload | no | 5 | `Peloton Tab` | The default number of workouts to download. See [choosing number of workouts to download](#choosing-number-of-workouts-to-download). Set this to `0` if you would like P2G to prompt you each time for a number to download. | | ExcludeWorkoutTypes | no | none | `Peloton Tab` | A comma separated list of workout types that you do not want P2G to download/convert/upload. See [example use cases](#exclude-workout-types) below. | @@ -251,7 +251,7 @@ This section provides settings related to uploading workouts to Garmin. | Field | Required | Default | UI Setting Location | Description | |:-----------|:---------|:--------|:--------------------|:------------| | Email | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin email used to sign in | -| Password | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin password used to sign in | +| Password | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin password used to sign in. **Note: Does not support `\` character in password** | | TwoStepVerificationEnabled | no | `false` | `Garmin Tab` | Whether or not your Garmin account is protected by Two Step Verification | | Upload | no | `false` | `Garmin Tab` | `true` indicates you wish downloaded workouts to be automatically uploaded to Garmin for you. | | FormatToUpload | no | `fit` | `Garmin Tab > Advanced` | Valid values are `fit` or `tcx`. Ensure the format you specify here is also enabled in your [Format config](#format-config) | diff --git a/src/Common/Configuration.cs b/src/Common/Configuration.cs index 2e7a67d8d..8c251ed13 100644 --- a/src/Common/Configuration.cs +++ b/src/Common/Configuration.cs @@ -9,8 +9,8 @@ public static void LoadConfigValues(IConfiguration provider, Settings config) { provider.GetSection(nameof(App)).Bind(config.App); provider.GetSection(nameof(Format)).Bind(config.Format); - provider.GetSection(nameof(PelotonSettings)).Bind(config.Peloton); - provider.GetSection(nameof(GarminSettings)).Bind(config.Garmin); + provider.GetSection("Peloton").Bind(config.Peloton); + provider.GetSection("Garmin").Bind(config.Garmin); } public static void LoadConfigValues(IConfiguration provider, AppConfiguration config) diff --git a/vNextReleaseNotes.md b/vNextReleaseNotes.md index 6336e58be..66890a9ce 100644 --- a/vNextReleaseNotes.md +++ b/vNextReleaseNotes.md @@ -9,6 +9,11 @@ ## Fixes - [#581] Fix broken Documentation link in UI +- [#580] Console Client couldn't load configuration file correctly (introduced by #564) + +## Docs + +- [#521] Called out that `\` special character is not currently supported in passwords ## Docker Tags