From d074226353881c004a3c665f3f7dc71d5338074c Mon Sep 17 00:00:00 2001
From: Corniel Nobel <corniel@gmail.com>
Date: Sat, 16 Nov 2024 20:51:24 +0100
Subject: [PATCH] Minor improvements (#287)

---
 Directory.Build.props                         |  9 ++++----
 .../Buildalyzer.Workspaces.csproj             |  4 +++-
 src/Buildalyzer/Buildalyzer.csproj            |  2 +-
 .../Buildalyzer.Tests.csproj                  | 21 ++++++++++++-------
 .../Buildalyzer.Workspaces.Tests.csproj       | 17 +++++++++------
 5 files changed, 33 insertions(+), 20 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 1bcd4419..eba5cebd 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -9,6 +9,7 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
 
   <PropertyGroup Label="Shared properties">
@@ -18,7 +19,7 @@
     <FileVersion>$(Version.Split('-')[0])</FileVersion>
     <LangVersion>12</LangVersion>
     <Nullable>enable</Nullable>
-    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <IsPublishable>false</IsPublishable>
   </PropertyGroup>
 
@@ -46,9 +47,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <None Include="$(MSBuildThisFileDirectory)\LICENSE.md" Pack="true" PackagePath=""/>
-    <None Include="$(MSBuildThisFileDirectory)\icon.png" Pack="true" PackagePath="\"/>
-    <None Include="$(MSBuildThisFileDirectory)\README.md" Pack="true" PackagePath="\"/>
+    <None Include="$(MSBuildThisFileDirectory)/LICENSE.md" Pack="true" PackagePath=""/>
+    <None Include="$(MSBuildThisFileDirectory)/icon.png" Pack="true" PackagePath="/"/>
+    <None Include="$(MSBuildThisFileDirectory)/README.md" Pack="true" PackagePath="/"/>
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj b/src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj
index 3bf2265f..7c13de6e 100644
--- a/src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj
+++ b/src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj
@@ -13,8 +13,10 @@
     <PackageValidationBaselineVersion>6.0.0</PackageValidationBaselineVersion>
     <OutputType>library</OutputType>
     <PackageReleaseNotes>
+      <![CDATA[
 ToBeReleased
 - Target .NET 8.0. #252
+]]>
     </PackageReleaseNotes>
   </PropertyGroup>
 
@@ -24,7 +26,7 @@ ToBeReleased
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Buildalyzer\Buildalyzer.csproj" />
+    <ProjectReference Include="../Buildalyzer/Buildalyzer.csproj" />
   </ItemGroup>
 
   <ItemGroup Label="Additional files">
diff --git a/src/Buildalyzer/Buildalyzer.csproj b/src/Buildalyzer/Buildalyzer.csproj
index ecbbbe93..73268142 100644
--- a/src/Buildalyzer/Buildalyzer.csproj
+++ b/src/Buildalyzer/Buildalyzer.csproj
@@ -36,7 +36,7 @@ ToBeReleased
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Buildalyzer.Logger\Buildalyzer.Logger.csproj" />
+    <ProjectReference Include="../Buildalyzer.Logger/Buildalyzer.Logger.csproj" />
   </ItemGroup>
 
   <ItemGroup Label="Additional files">
diff --git a/tests/Buildalyzer.Tests/Buildalyzer.Tests.csproj b/tests/Buildalyzer.Tests/Buildalyzer.Tests.csproj
index 7ccf5a51..b84ae6fe 100644
--- a/tests/Buildalyzer.Tests/Buildalyzer.Tests.csproj
+++ b/tests/Buildalyzer.Tests/Buildalyzer.Tests.csproj
@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
+    <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
     <OutputType>library</OutputType>
   </PropertyGroup>
@@ -11,16 +12,20 @@
     <PackageReference Update="Microsoft.CodeAnalysis.CSharp" Version="4.*" />
     <PackageReference Update="Microsoft.CodeAnalysis.VisualBasic" Version="4.*" />
   </ItemGroup>
-  
+
   <ItemGroup>
-    <PackageReference Include="FluentAssertions" Version="6.12.0" />
-    <PackageReference Include="LibGit2Sharp" Version="0.27.0-preview-0175" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+    <PackageReference Include="FluentAssertions" Version="6.12.2" />
+    <PackageReference Include="LibGit2Sharp" Version="0.30.0" />
+    
     <PackageReference Include="MsBuildPipeLogger.Logger" Version="1.1.6" GeneratePathProperty="true" />
-    <PackageReference Include="NUnit" Version="4.1.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="*" PrivateAssets="all" />
+    <PackageReference Include="NUnit" Version="4.2.2" />
     <PackageReference Include="Shouldly" Version="4.2.1" />
-    </ItemGroup>
+  </ItemGroup>
+
+  <ItemGroup Label="Build tools">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="*" PrivateAssets="all" />
+    <PackageReference Include="NUnit3TestAdapter" Version="*" PrivateAssets="all" />
+  </ItemGroup>
 
   <ItemGroup Label="Analyzers">
     <PackageReference Include="FluentAssertions.Analyzers" Version="*" PrivateAssets="all" />
@@ -28,7 +33,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\src\Buildalyzer\Buildalyzer.csproj" />
+    <ProjectReference Include="../../src/Buildalyzer/Buildalyzer.csproj" />
   </ItemGroup>
 
   <ItemGroup Label="Additional files">
diff --git a/tests/Buildalyzer.Workspaces.Tests/Buildalyzer.Workspaces.Tests.csproj b/tests/Buildalyzer.Workspaces.Tests/Buildalyzer.Workspaces.Tests.csproj
index d7239a1b..6a2d4c81 100644
--- a/tests/Buildalyzer.Workspaces.Tests/Buildalyzer.Workspaces.Tests.csproj
+++ b/tests/Buildalyzer.Workspaces.Tests/Buildalyzer.Workspaces.Tests.csproj
@@ -2,27 +2,32 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
+    <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
     <OutputType>library</OutputType>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentAssertions" Version="6.12.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+    <PackageReference Include="FluentAssertions" Version="6.12.2" />
     <PackageReference Include="MsBuildPipeLogger.Logger" Version="1.1.6" GeneratePathProperty="true" />
-    <PackageReference Include="NUnit" Version="4.1.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="*" PrivateAssets="all" />
+    <PackageReference Include="NUnit" Version="4.2.2" />
     <PackageReference Include="Shouldly" Version="4.2.1" />
   </ItemGroup>
 
+  <ItemGroup Label="Build tools">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="*" PrivateAssets="all" />
+    <PackageReference Include="NUnit3TestAdapter" Version="*" PrivateAssets="all" />
+  </ItemGroup>
+
+
   <ItemGroup Label="Analyzers">
     <PackageReference Include="FluentAssertions.Analyzers" Version="*" PrivateAssets="all" />
     <PackageReference Include="NUnit.Analyzers" Version="*" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\src\Buildalyzer.Workspaces\Buildalyzer.Workspaces.csproj" />
-    <ProjectReference Include="..\Buildalyzer.Tests\Buildalyzer.Tests.csproj" />
+    <ProjectReference Include="../../src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj" />
+    <ProjectReference Include="../Buildalyzer.Tests/Buildalyzer.Tests.csproj" />
   </ItemGroup>
 
   <ItemGroup Label="Additional files">